Please consider the following formatting changes to #10954 #10955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes in this commit focus on improving the selection of He-V0 candidates by introducing a 2-body vertex finding step. The key changes are: 1. Added a 2-body vertex fitter (DCAFitterN<2>) to process the positive and negative tracks and obtain the PCA (point of closest approach) candidate. 2. Calculated the cosine of the pointing angle and applied a cut on this value to further select the He-V0 candidates. 3. Refactored the existing He-V0 selection logic to use the new 2-body vertex information.
alibuild
requested review from
ChiaraDeMartin95,
ercolessi,
lietava and
mpuccio
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your PR #10954 cannot be merged as is. You should either run
clang-formatyourself and update the pull request, or merge this PR in yours.You can find the AliceO2 coding conventions at https://github.com/AliceO2Group/CodingGuidelines.