Skip to content

[PWGEM/Dilepton] fix DCA calculation #10912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dsekihat merged 3 commits into from
Apr 18, 2025
Merged

[PWGEM/Dilepton] fix DCA calculation #10912

dsekihat merged 3 commits into from
Apr 18, 2025

Conversation

@dsekihat
Copy link
Collaborator

@dsekihat dsekihat commented Apr 18, 2025

PWGEM/Dilepton: fix DCA calculation

@github-actions github-actions bot added the pwgem label Apr 18, 2025
@github-actions github-actions bot changed the title PWGEM/Dilepton: fix DCA calculation [PWGEM/Dilepton] fix DCA calculation Apr 18, 2025
@dsekihat dsekihat enabled auto-merge (squash) April 18, 2025 12:53
alibuild
alibuild previously approved these changes Apr 18, 2025
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @dsekihat.

@dsekihat dsekihat disabled auto-merge April 18, 2025 13:11
@alibuild alibuild mentioned this pull request Apr 18, 2025
Merged
dsekihat added a commit to dsekihat/O2Physics that referenced this pull request Apr 18, 2025
@dsekihat
Merge pull request #37 from alibuild/alibot-cleanup-10912
3918641 
Please consider the following formatting changes to AliceO2Group#10912
@dsekihat dsekihat enabled auto-merge (squash) April 18, 2025 13:15
alibuild
alibuild approved these changes Apr 18, 2025
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @dsekihat.

@dsekihat dsekihat disabled auto-merge April 18, 2025 13:29
@dsekihat dsekihat enabled auto-merge (squash) April 18, 2025 13:29
alibuild
alibuild previously approved these changes Apr 18, 2025
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @dsekihat.

@alibuild
Copy link
Collaborator

alibuild commented Apr 18, 2025

Error while checking build/O2Physics/o2 for 3918641 at 2025-04-18 16:24:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
/sw/SOURCES/O2Physics/10912-slc9_x86-64/0/PWGEM/Dilepton/Utils/EMTrackUtilities.h:33:30: error: 'dca3DinSigma' was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive]
/sw/SOURCES/O2Physics/10912-slc9_x86-64/0/PWGEM/Dilepton/Utils/EMTrackUtilities.h:82:9: error: unused variable 'dcaXY' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/10912-slc9_x86-64/0/PWGEM/Dilepton/Utils/EMTrackUtilities.h:71:33: error: 'fwdDcaXYinSigma' was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive]
/sw/SOURCES/O2Physics/10912-slc9_x86-64/0/PWGEM/Dilepton/Utils/EMTrackUtilities.h:33:30: error: 'dca3DinSigma' was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive]
/sw/SOURCES/O2Physics/10912-slc9_x86-64/0/PWGEM/Dilepton/Utils/EMTrackUtilities.h:82:9: error: unused variable 'dcaXY' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/10912-slc9_x86-64/0/PWGEM/Dilepton/Utils/EMTrackUtilities.h:71:33: error: 'fwdDcaXYinSigma' was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive]
/sw/SOURCES/O2Physics/10912-slc9_x86-64/0/PWGEM/Dilepton/Utils/EMTrackUtilities.h:82:9: error: unused variable 'dcaXY' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/10912-slc9_x86-64/0/PWGEM/Dilepton/Utils/EMTrackUtilities.h:82:9: error: unused variable 'dcaXY' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/10912-slc9_x86-64/0/PWGEM/Dilepton/Utils/EMTrackUtilities.h:82:9: error: unused variable 'dcaXY' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

@dsekihat dsekihat disabled auto-merge April 18, 2025 21:01
@alibuild alibuild mentioned this pull request Apr 18, 2025
Merged
@dsekihat
Merge pull request #38 from alibuild/alibot-cleanup-10912
8d323e7 
[PWGEM] Please consider the following formatting changes to AliceO2Group#10912
@dsekihat dsekihat enabled auto-merge (squash) April 18, 2025 21:03
alibuild
alibuild approved these changes Apr 18, 2025
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @dsekihat.

@dsekihat dsekihat merged commit 421df5d into AliceO2Group:master Apr 18, 2025
12 of 13 checks passed
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request May 17, 2025
@dsekihat @alibuild
[PWGEM/Dilepton] fix DCA calculation (AliceO2Group#10912)
7da5d56 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ariedel-cern pushed a commit to ariedel-cern/O2Physics that referenced this pull request May 23, 2025
@dsekihat @alibuild @ariedel-cern
[PWGEM/Dilepton] fix DCA calculation (AliceO2Group#10912)
ff42247 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Jun 17, 2025
@dsekihat @alibuild @smaff92
[PWGEM/Dilepton] fix DCA calculation (AliceO2Group#10912)
b3e53fb 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
alibuild added a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
@dsekihat @alibuild @CesarOmarRA
[PWGEM/Dilepton] fix DCA calculation (AliceO2Group#10912)
728b129 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild alibuild approved these changes

@mikesas mikesas Awaiting requested review from mikesas mikesas is a code owner

@rbailhac rbailhac Awaiting requested review from rbailhac rbailhac is a code owner

@ivorobye ivorobye Awaiting requested review from ivorobye ivorobye is a code owner

@feisenhu feisenhu Awaiting requested review from feisenhu feisenhu is a code owner

Assignees

No one assigned

Labels

pwgem

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dsekihat @alibuild