[PWGCF] DptDpt - Increasing the level of pT bins tracking #10887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also - fixed `linter` magic number usage recommendations - don't process individual tracks if only pairs are required
victor-gonzalez
requested review from
alibuild,
ariedel-cern,
glromane,
lauraser,
lgraczykCern,
otonvd,
prchakra,
saganatt,
shouqiye and
zchochul
as code owners
vkucera
reviewed
Apr 16, 2025
Comment on lines
395
to
396
| constexpr int kFiftyPerCent = 50.0f; | ||
| constexpr int kHundredPerCent = 100.0f; |
Collaborator
There was a problem hiding this comment.
Shouldn't these be float?
Collaborator
Author
There was a problem hiding this comment.
Yes!
They should!
Thanks!
Collaborator
Author
There was a problem hiding this comment.
But it will go in the next iteration probably tomorrow
alibuild
approved these changes
Apr 16, 2025
Collaborator
alibuild
left a comment
alibuild
left a comment
There was a problem hiding this comment.
Auto-approving on behalf of @victor-gonzalez.
prottayCMT
pushed a commit
to prottayCMT/O2Physics2024
that referenced
this pull request
May 17, 2025
…up#10887) Co-authored-by: Victor <victor@cern.ch>
ariedel-cern
pushed a commit
to ariedel-cern/O2Physics
that referenced
this pull request
May 23, 2025
…up#10887) Co-authored-by: Victor <victor@cern.ch>
smaff92
pushed a commit
to smaff92/O2Physics
that referenced
this pull request
Jun 17, 2025
…up#10887) Co-authored-by: Victor <victor@cern.ch>
alibuild
pushed a commit
to alibuild/O2Physics
that referenced
this pull request
Aug 11, 2025
…up#10887) Co-authored-by: Victor <victor@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also
lintermagic number usage recommendations