Skip to content

[PWGHF] Added centrality to D+ tree tables #10876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhangbiao-phy merged 11 commits into from
Apr 18, 2025
Merged

[PWGHF] Added centrality to D+ tree tables #10876

zhangbiao-phy merged 11 commits into from
Apr 18, 2025

Conversation

@Marcellocosti
Copy link
Contributor

@Marcellocosti Marcellocosti commented Apr 16, 2025

This PR adds the centrality information in the D+ tables in the treeCreatorDplusToPiKPi.cxx workflow

@github-actions github-actions bot added the pwghf PWG-HF label Apr 16, 2025
@Marcellocosti Marcellocosti marked this pull request as ready for review April 16, 2025 14:51
@zhangbiao-phy
Copy link
Collaborator

zhangbiao-phy commented Apr 16, 2025 •
edited
Loading

Ciao @Marcellocosti, Thanks for the development! looks good to me! I only have one comment, could you also keep the default process function without the centrality option for data and mc? since we always want to keep it for the people who are interested in the MB analysis.

@alibuild alibuild mentioned this pull request Apr 17, 2025
Merged
@Marcellocosti
Copy link
Contributor Author

Marcellocosti commented Apr 17, 2025

Hi @zhangbiao-phy, thanks for the suggestion! I tried to implement your request, by introducing two additional process functions. Please let me know if this is what you meant or further adjustments are needed!

@zhangbiao-phy
Copy link
Collaborator

zhangbiao-phy commented Apr 17, 2025 •
edited
Loading

Hi @zhangbiao-phy, thanks for the suggestion! I tried to implement your request, by introducing two additional process functions. Please let me know if this is what you meant or further adjustments are needed!

Thanks! Could you also fix the formatting?

@zhangbiao-phy zhangbiao-phy reopened this Apr 17, 2025
Marcellocosti added a commit to Marcellocosti/O2Physics that referenced this pull request Apr 17, 2025
@Marcellocosti
Merge pull request #10 from alibuild/alibot-cleanup-10876
b81ea13 
[PWGHF] Please consider the following formatting changes to AliceO2Group#10876
@Marcellocosti Marcellocosti mentioned this pull request Apr 17, 2025
Closed
@vkucera
Copy link
Collaborator

vkucera commented Apr 17, 2025

Please force-push the commit b81ea13 so that the PR can be reopened.

@vkucera
Copy link
Collaborator

vkucera commented Apr 17, 2025

If you can't get that commit, try ed51ab4 which is still in your remote branch.

@Marcellocosti Marcellocosti reopened this Apr 17, 2025
@alibuild alibuild mentioned this pull request Apr 17, 2025
Merged
@Marcellocosti
Merge pull request #13 from alibuild/alibot-cleanup-10876
f1b64a2 
[PWGHF] Please consider the following formatting changes to AliceO2Group#10876
@Marcellocosti
Copy link
Contributor Author

Marcellocosti commented Apr 17, 2025

Dear @vkucera, indeed I managed to recover the original PR, thanks for the help!

@zhangbiao-phy zhangbiao-phy enabled auto-merge (squash) April 18, 2025 10:02
@zhangbiao-phy zhangbiao-phy disabled auto-merge April 18, 2025 10:16
@zhangbiao-phy zhangbiao-phy merged commit 730dec6 into AliceO2Group:master Apr 18, 2025
14 checks passed
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request May 17, 2025
@Marcellocosti @alibuild
[PWGHF] Added centrality to D+ tree tables (AliceO2Group#10876)
3df15ef 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ariedel-cern pushed a commit to ariedel-cern/O2Physics that referenced this pull request May 23, 2025
@Marcellocosti @alibuild @ariedel-cern
[PWGHF] Added centrality to D+ tree tables (AliceO2Group#10876)
40fd98c 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Jun 17, 2025
@Marcellocosti @alibuild @smaff92
[PWGHF] Added centrality to D+ tree tables (AliceO2Group#10876)
f6ace8f 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
alibuild added a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
@Marcellocosti @alibuild @CesarOmarRA
[PWGHF] Added centrality to D+ tree tables (AliceO2Group#10876)
1812bd6 
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhangbiao-phy zhangbiao-phy zhangbiao-phy approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@vkucera vkucera Awaiting requested review from vkucera vkucera is a code owner

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner

@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner

@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner

@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner

@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner

@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner

@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner

@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner

@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner

Assignees

No one assigned

Labels

pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Marcellocosti @zhangbiao-phy @vkucera @alibuild