Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
// Produces<aod::FdMCParticles> outputPartsMC;

// Analysis configs
Configurable<bool> ConfIsTrigger{"ConfIsTrigger", false, "Store all collisions"}; // Choose if filtering or skimming version is run

Check warning on line 86 in PWGCF/FemtoUniverse/TableProducer/femtoUniverseProducerMCTruthTask.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/function-variable]

Use lowerCamelCase for names of functions and variables.
Configurable<bool> ConfIsRun3{"ConfIsRun3", false, "Running on Run3 or pilot"};
Configurable<bool> ConfIsMC{"ConfIsMC", false, "Running on MC; implemented only for Run3"};
Configurable<bool> ConfIsForceGRP{"ConfIsForceGRP", false, "Set true if the magnetic field configuration is not available in the usual CCDB directory (e.g. for Run 2 converted data or unanchorad Monte Carlo)"};
Expand Down Expand Up @@ -137,7 +137,7 @@
template <typename CollisionType, typename TrackType>
void fillCollisions(CollisionType const& col, TrackType const& /*tracks*/)
{
for (auto& c : col) {

Check warning on line 140 in PWGCF/FemtoUniverse/TableProducer/femtoUniverseProducerMCTruthTask.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop]

Use constant references for non-modified iterators in range-based for loops.
const auto vtxZ = c.posZ();
const auto spher = 0; // colCuts.computeSphericity(col, tracks);
int mult = 0;
Expand All @@ -153,7 +153,7 @@
{
std::vector<int> childIDs = {0, 0}; // these IDs are necessary to keep track of the children

for (auto& particle : tracks) {

Check warning on line 156 in PWGCF/FemtoUniverse/TableProducer/femtoUniverseProducerMCTruthTask.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop]

Use constant references for non-modified iterators in range-based for loops.
/// if the most open selection criteria are not fulfilled there is no
/// point looking further at the track

Expand All @@ -167,10 +167,12 @@
if (ConfAnalysisWithPID) {
bool pass = false;
std::vector<int> tmpPDGCodes = ConfPDGCodes; // necessary due to some features of the Configurable
for (uint32_t pdg : tmpPDGCodes) {

Check warning on line 170 in PWGCF/FemtoUniverse/TableProducer/femtoUniverseProducerMCTruthTask.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop]

Use constant references for non-modified iterators in range-based for loops.
if (pdgCode == 333) {
if (pdgCode == 333) { // phi meson

Check warning on line 171 in PWGCF/FemtoUniverse/TableProducer/femtoUniverseProducerMCTruthTask.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number]

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.

Check warning on line 171 in PWGCF/FemtoUniverse/TableProducer/femtoUniverseProducerMCTruthTask.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/explicit-code]

Avoid using hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
pass = true;
} else if (pdgCode == 421) {
} else if (pdgCode == 421) { // D0 meson

Check warning on line 173 in PWGCF/FemtoUniverse/TableProducer/femtoUniverseProducerMCTruthTask.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number]

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.

Check warning on line 173 in PWGCF/FemtoUniverse/TableProducer/femtoUniverseProducerMCTruthTask.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/explicit-code]

Avoid using hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
pass = true;
} else if (pdgCode == 411) { // D+ meson

Check warning on line 175 in PWGCF/FemtoUniverse/TableProducer/femtoUniverseProducerMCTruthTask.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number]

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.

Check warning on line 175 in PWGCF/FemtoUniverse/TableProducer/femtoUniverseProducerMCTruthTask.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/explicit-code]

Avoid using hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
pass = true;
} else if (static_cast<int>(pdg) == static_cast<int>(pdgCode)) {
if (particle.isPhysicalPrimary())
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1565,7 +1565,8 @@ struct FemtoUniverseProducerTask {
} else {
if (!(isKaonNSigma(p1.pt(), trackCuts.getNsigmaTPC(p1, o2::track::PID::Kaon), trackCuts.getNsigmaTOF(p1, o2::track::PID::Kaon)))) {
continue;
} else if (!(isKaonNSigma(p2.pt(), trackCuts.getNsigmaTPC(p2, o2::track::PID::Kaon), trackCuts.getNsigmaTOF(p2, o2::track::PID::Kaon)))) {
}
if (!(isKaonNSigma(p2.pt(), trackCuts.getNsigmaTPC(p2, o2::track::PID::Kaon), trackCuts.getNsigmaTOF(p2, o2::track::PID::Kaon)))) {
continue;
}
}
Expand Down
Loading