Skip to content

[PWGLF] Resonance Framework: Add RCT Flag checker #10859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
njacazio merged 5 commits into from
Apr 16, 2025
Merged

[PWGLF] Resonance Framework: Add RCT Flag checker #10859

njacazio merged 5 commits into from
Apr 16, 2025

Conversation

@BongHwi
Copy link
Collaborator

@BongHwi BongHwi commented Apr 15, 2025

Add common RCT flag checker helper, disabled by default.

@github-actions github-actions bot added the pwglf label Apr 15, 2025
dmallick2
dmallick2 previously approved these changes Apr 15, 2025
View reviewed changes
@dmallick2 dmallick2 enabled auto-merge (squash) April 15, 2025 14:06
njacazio
njacazio previously approved these changes Apr 15, 2025
View reviewed changes
Copy link
Collaborator

@njacazio njacazio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @BongHwi

@BongHwi BongHwi dismissed stale reviews from njacazio and dmallick2 via 9803725 April 15, 2025 16:22
dmallick2
dmallick2 previously approved these changes Apr 15, 2025
View reviewed changes
@alibuild
Copy link
Collaborator

alibuild commented Apr 15, 2025

Error while checking build/O2Physics/o2 for 1ca5b7e at 2025-04-15 19:28:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/10859-slc9_x86-64/0/PWGLF/TableProducer/Resonances/resonanceModuleInitializer.cxx:114:3: error: 'RCTFlagsChecker' does not name a type
/sw/SOURCES/O2Physics/10859-slc9_x86-64/0/PWGLF/TableProducer/Resonances/resonanceModuleInitializer.cxx:539:37: error: 'myChecker' was not declared in this scope
/sw/SOURCES/O2Physics/10859-slc9_x86-64/0/PWGLF/TableProducer/Resonances/resonanceModuleInitializer.cxx:584:37: error: 'myChecker' was not declared in this scope
/sw/SOURCES/O2Physics/10859-slc9_x86-64/0/PWGLF/TableProducer/Resonances/resonanceInitializer.cxx:127:3: error: 'RCTFlagsChecker' does not name a type
/sw/SOURCES/O2Physics/10859-slc9_x86-64/0/PWGLF/TableProducer/Resonances/resonanceInitializer.cxx:1296:47: error: 'myChecker' was not declared in this scope
/sw/SOURCES/O2Physics/10859-slc9_x86-64/0/PWGLF/TableProducer/Resonances/resonanceInitializer.cxx:1322:47: error: 'myChecker' was not declared in this scope
/sw/SOURCES/O2Physics/10859-slc9_x86-64/0/PWGLF/TableProducer/Resonances/resonanceInitializer.cxx:1349:47: error: 'myChecker' was not declared in this scope
/sw/SOURCES/O2Physics/10859-slc9_x86-64/0/PWGLF/TableProducer/Resonances/resonanceInitializer.cxx:1376:47: error: 'myChecker' was not declared in this scope
/sw/SOURCES/O2Physics/10859-slc9_x86-64/0/PWGLF/TableProducer/Resonances/resonanceInitializer.cxx:1432:47: error: 'myChecker' was not declared in this scope
/sw/SOURCES/O2Physics/10859-slc9_x86-64/0/PWGLF/TableProducer/Resonances/resonanceInitializer.cxx:1486:47: error: 'myChecker' was not declared in this scope
/sw/SOURCES/O2Physics/10859-slc9_x86-64/0/PWGLF/TableProducer/Resonances/resonanceInitializer.cxx:1518:47: error: 'myChecker' was not declared in this scope
/sw/SOURCES/O2Physics/10859-slc9_x86-64/0/PWGLF/TableProducer/Resonances/resonanceInitializer.cxx:1575:47: error: 'myChecker' was not declared in this scope
/sw/SOURCES/O2Physics/10859-slc9_x86-64/0/PWGLF/TableProducer/Resonances/resonanceInitializer.cxx:1637:47: error: 'myChecker' was not declared in this scope
ninja: build stopped: subcommand failed.

Full log here.

@BongHwi BongHwi marked this pull request as draft April 15, 2025 17:32
auto-merge was automatically disabled April 15, 2025 17:32

Pull request was converted to draft

dmallick2
dmallick2 previously approved these changes Apr 15, 2025
View reviewed changes
@BongHwi BongHwi marked this pull request as ready for review April 15, 2025 19:10
@njacazio njacazio merged commit 6a56488 into AliceO2Group:master Apr 16, 2025
12 of 13 checks passed
@BongHwi BongHwi deleted the ResoRCTFlagChecker branch April 16, 2025 17:55
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request May 17, 2025
@BongHwi
[PWGLF] Resonance Framework: Add RCT Flag checker (AliceO2Group#10859)
f84071d
ariedel-cern pushed a commit to ariedel-cern/O2Physics that referenced this pull request May 23, 2025
@BongHwi @ariedel-cern
[PWGLF] Resonance Framework: Add RCT Flag checker (AliceO2Group#10859)
bf62a71
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Jun 17, 2025
@BongHwi @smaff92
[PWGLF] Resonance Framework: Add RCT Flag checker (AliceO2Group#10859)
8182602
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
@BongHwi @CesarOmarRA
[PWGLF] Resonance Framework: Add RCT Flag checker (AliceO2Group#10859)
8a32d43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@njacazio njacazio njacazio approved these changes

@dmallick2 dmallick2 dmallick2 left review comments

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner

@smaff92 smaff92 Awaiting requested review from smaff92 smaff92 is a code owner

Assignees

No one assigned

Labels

pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BongHwi @alibuild @njacazio @dmallick2