Skip to content

Conversation

@vkucera
Copy link
Collaborator

@vkucera vkucera commented Apr 11, 2025

  • Rename classes to match the test names better.
  • Report summary only for failed or disabled tests.
  • Add test rationales and references.
  • Fix bugs and improve performance.
  • std-prefix: Simplify test.
  • root-entity: Rename to root/entity.
  • magic-number: Extend pattern. Fix false positives. Support multiple matches per line.
  • Add root/lorentz-vector.
  • Add pdg/explicit-mass.

- Rename classes to match the test names better.
- `std-prefix`: Simplify test.
- `root-entity`: Rename to `root/entity`.
- `magic-number`: Extend pattern. Fix false positives. Support multiple matches per line.
- Add `root/lorentz-vector`.
- Add `pdg/explicit-mass`.
@vkucera vkucera marked this pull request as ready for review April 11, 2025 16:08
@vkucera vkucera requested review from a team, alibuild, ddobrigk, iarsene, jgrosseo and ktf as code owners April 11, 2025 16:08
@vkucera vkucera marked this pull request as draft April 11, 2025 16:11
@vkucera vkucera marked this pull request as ready for review April 11, 2025 16:15
@vkucera vkucera marked this pull request as draft April 15, 2025 16:12
@vkucera vkucera marked this pull request as ready for review April 15, 2025 20:00
@vkucera vkucera enabled auto-merge (squash) April 15, 2025 20:01
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @vkucera.

@vkucera vkucera merged commit da01790 into AliceO2Group:master Apr 15, 2025
15 checks passed
@vkucera vkucera deleted the o2linter branch April 15, 2025 21:23
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request May 17, 2025
ariedel-cern pushed a commit to ariedel-cern/O2Physics that referenced this pull request May 23, 2025
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Jun 17, 2025
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants