Skip to content

[PWGDQ] Removing ambiguous histogram filling #10801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucamicheletti93 merged 1 commit into from
Apr 9, 2025
+0 −3
Merged

[PWGDQ] Removing ambiguous histogram filling #10801

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions PWGDQ/TableProducer/tableMakerMC.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
// The skimmed MC stack includes the MC truth particles corresponding to the list of user specified MC signals (see MCsignal.h)
// and the MC truth particles corresponding to the reconstructed tracks selected by the specified track cuts on reconstructed data.

#include <iostream>

Check warning on line 19 in PWGDQ/TableProducer/tableMakerMC.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[include-iostream] 

Do not include iostream. Use O2 logging instead.
#include <string>
#include <map>
#include <memory>
Expand Down Expand Up @@ -762,9 +762,6 @@
for (auto& cut : fMuonCuts) {
if (cut.IsSelected(VarManager::fgValues)) {
trackTempFilterMap |= (uint8_t(1) << i);
if (fConfigQA) {
fHistMan->FillHistClass(Form("Muons_%s", cut.GetName()), VarManager::fgValues);
}
(reinterpret_cast<TH1I*>(fStatsList->At(2)))->Fill(static_cast<float>(i));
}
i++;
Expand Down Expand Up @@ -934,8 +931,8 @@
mothers.push_back(fNewLabels.find(m)->second);
}
} else {
cout << "Mother label (" << m << ") exceeds the McParticles size (" << mcTracks.size() << ")" << endl;

Check warning on line 934 in PWGDQ/TableProducer/tableMakerMC.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[logging] 

Use O2 logging (LOG, LOGF, LOGP).
cout << " Check the MC generator" << endl;

Check warning on line 935 in PWGDQ/TableProducer/tableMakerMC.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[logging] 

Use O2 logging (LOG, LOGF, LOGP).
}
}
}
Expand All @@ -951,8 +948,8 @@
daughters.push_back(fNewLabels.find(d)->second);
}
} else {
cout << "Daughter label (" << d << ") exceeds the McParticles size (" << mcTracks.size() << ")" << endl;

Check warning on line 951 in PWGDQ/TableProducer/tableMakerMC.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[logging] 

Use O2 logging (LOG, LOGF, LOGP).
cout << " Check the MC generator" << endl;

Check warning on line 952 in PWGDQ/TableProducer/tableMakerMC.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[logging] 

Use O2 logging (LOG, LOGF, LOGP).
}
}
}
Expand Down Expand Up @@ -1476,8 +1473,8 @@
mothers.push_back(fNewLabels.find(m)->second);
}
} else {
cout << "Mother label (" << m << ") exceeds the McParticles size (" << mcTracks.size() << ")" << endl;

Check warning on line 1476 in PWGDQ/TableProducer/tableMakerMC.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[logging] 

Use O2 logging (LOG, LOGF, LOGP).
cout << " Check the MC generator" << endl;

Check warning on line 1477 in PWGDQ/TableProducer/tableMakerMC.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[logging] 

Use O2 logging (LOG, LOGF, LOGP).
}
}
}
Expand All @@ -1493,8 +1490,8 @@
daughters.push_back(fNewLabels.find(d)->second);
}
} else {
cout << "Daughter label (" << d << ") exceeds the McParticles size (" << mcTracks.size() << ")" << endl;

Check warning on line 1493 in PWGDQ/TableProducer/tableMakerMC.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[logging] 

Use O2 logging (LOG, LOGF, LOGP).
cout << " Check the MC generator" << endl;

Check warning on line 1494 in PWGDQ/TableProducer/tableMakerMC.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[logging] 

Use O2 logging (LOG, LOGF, LOGP).
}
}
}
Expand Down Expand Up @@ -1530,7 +1527,7 @@
void DefineHistograms(TString histClasses)
{
std::unique_ptr<TObjArray> objArray(histClasses.Tokenize(";"));
for (Int_t iclass = 0; iclass < objArray->GetEntries(); ++iclass) {

Check warning on line 1530 in PWGDQ/TableProducer/tableMakerMC.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[root-entity] 

Replace ROOT entities with equivalents from standard C++ or from O2.
TString classStr = objArray->At(iclass)->GetName();
if (fConfigQA) {
fHistMan->AddHistClass(classStr.Data());
Expand Down
Loading