Skip to content

[PWGJE,EMCAL-850] Add TVX check histogram for EMCal QA #10767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mhemmer-cern merged 2 commits into from
Apr 5, 2025
Merged

[PWGJE,EMCAL-850] Add TVX check histogram for EMCal QA #10767

mhemmer-cern merged 2 commits into from
Apr 5, 2025

Conversation

@mhemmer-cern
Copy link
Collaborator

@mhemmer-cern mhemmer-cern commented Apr 4, 2025

  • Add histogram to check if there are any EMCinTVX collisions without TVX
  • Make last adjustments for O2Linter

@github-actions github-actions bot added the pwgje label Apr 4, 2025
@alibuild
Copy link
Collaborator

alibuild commented Apr 4, 2025

Error while checking build/O2Physics/o2 for 40982e3 at 2025-04-04 18:06:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/10767-slc9_x86-64/0/PWGJE/Tasks/emcEventSelectionQA.cxx:45:15: error: unused variable 'mRun3MinNumber' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/10767-slc9_x86-64/0/PWGJE/Tasks/emcEventSelectionQA.cxx:123:28: error: 'mRun3MinNumber' was not declared in this scope
ninja: build stopped: subcommand failed.

Full log here.

fjonasALICE
fjonasALICE previously approved these changes Apr 4, 2025
View reviewed changes
@fjonasALICE fjonasALICE enabled auto-merge (squash) April 4, 2025 22:01
@mhemmer-cern
[PWGJE,EMCAL-850] Add TVX check histogram for EMCal QA
1f8ca5b 
- Add histogram to check if there are any EMCinTVX collisions without TVX
- Make last adjustments for O2Linter
@mhemmer-cern
[PWGJE,EMCAL-850] Fix missplaced variable decleration
11d0162
@mhemmer-cern mhemmer-cern disabled auto-merge April 5, 2025 11:18
@mhemmer-cern mhemmer-cern enabled auto-merge (squash) April 5, 2025 11:18
alibuild
alibuild approved these changes Apr 5, 2025
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @mhemmer-cern.

@mhemmer-cern mhemmer-cern merged commit ba15342 into AliceO2Group:master Apr 5, 2025
12 of 13 checks passed
louisemillot pushed a commit to louisemillot/O2Physics that referenced this pull request Apr 8, 2025
@mhemmer-cern @louisemillot
[PWGJE,EMCAL-850] Add TVX check histogram for EMCal QA (AliceO2Group#…
e707540 
…10767)
njacazio pushed a commit that referenced this pull request Apr 11, 2025
@mhemmer-cern @njacazio
[PWGJE,EMCAL-850] Add TVX check histogram for EMCal QA (#10767)
8dc9661
ariedel-cern pushed a commit to ariedel-cern/O2Physics that referenced this pull request May 23, 2025
@mhemmer-cern @ariedel-cern
[PWGJE,EMCAL-850] Add TVX check histogram for EMCal QA (AliceO2Group#…
fdb19ed 
…10767)
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Jun 17, 2025
@mhemmer-cern @smaff92
[PWGJE,EMCAL-850] Add TVX check histogram for EMCal QA (AliceO2Group#…
caa8409 
…10767)
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
@mhemmer-cern @CesarOmarRA
[PWGJE,EMCAL-850] Add TVX check histogram for EMCal QA (AliceO2Group#…
092719b 
…10767)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild alibuild approved these changes

@fjonasALICE fjonasALICE fjonasALICE left review comments

@maoyx maoyx Awaiting requested review from maoyx maoyx is a code owner

@nzardosh nzardosh Awaiting requested review from nzardosh nzardosh is a code owner

@mfasDa mfasDa Awaiting requested review from mfasDa mfasDa is a code owner

Assignees

No one assigned

Labels

pwgje

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mhemmer-cern @alibuild @fjonasALICE