Skip to content

[PWGLF] fix o2linter complaints for magic numbers #10729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chiarapinto merged 1 commit into from
Apr 2, 2025
Merged

[PWGLF] fix o2linter complaints for magic numbers #10729

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 28 additions & 12 deletions PWGLF/Tasks/Nuspex/antinucleiInJets.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,27 +364,39 @@ struct AntinucleiInJets {
template <typename JetTrack>
bool passedTrackSelectionForJetReconstruction(const JetTrack& track)
{

const int minTpcCr = 70;
const double minCrFindable = 0.8;
const double maxChi2Tpc = 4.0;
const double maxChi2Its = 36.0;
const double maxPseudorapidity = 0.8;
const double minPtTrack = 0.1;
const double dcaxyMaxTrackPar0 = 0.0105;
const double dcaxyMaxTrackPar1 = 0.035;
const double dcaxyMaxTrackPar2 = 1.1;
const double dcazMaxTrack = 2.0;

if (!track.hasITS())
return false;
if ((!hasITSHit(track, 1)) && (!hasITSHit(track, 2)) && (!hasITSHit(track, 3)))
return false;
if (!track.hasTPC())
return false;
if (track.tpcNClsCrossedRows() < 70)
if (track.tpcNClsCrossedRows() < minTpcCr)
return false;
if ((static_cast<double>(track.tpcNClsCrossedRows()) / static_cast<double>(track.tpcNClsFindable())) < 0.8)
if ((static_cast<double>(track.tpcNClsCrossedRows()) / static_cast<double>(track.tpcNClsFindable())) < minCrFindable)
return false;
if (track.tpcChi2NCl() > 4)
if (track.tpcChi2NCl() > maxChi2Tpc)
return false;
if (track.itsChi2NCl() > 36)
if (track.itsChi2NCl() > maxChi2Its)
return false;
if (track.eta() < -0.8 || track.eta() > 0.8)
if (track.eta() < -maxPseudorapidity || track.eta() > maxPseudorapidity)
return false;
if (track.pt() < 0.1)
if (track.pt() < minPtTrack)
return false;
if (std::fabs(track.dcaXY()) > (0.0105 + 0.035 / std::pow(track.pt(), 1.1)))
if (std::fabs(track.dcaXY()) > (dcaxyMaxTrackPar0 + dcaxyMaxTrackPar1 / std::pow(track.pt(), dcaxyMaxTrackPar2)))
return false;
if (std::fabs(track.dcaZ()) > 2.0)
if (std::fabs(track.dcaZ()) > dcazMaxTrack)
return false;
return true;
}
Expand Down Expand Up @@ -424,10 +436,12 @@ struct AntinucleiInJets {
double nsigmaTPCPr = track.tpcNSigmaPr();
double nsigmaTOFPr = track.tofNSigmaPr();
double pt = track.pt();
double ptThreshold = 0.5;
double nsigmaMaxPr = 2.0;

if (pt < 0.5 && std::fabs(nsigmaTPCPr) < 2.0)
if (pt < ptThreshold && std::fabs(nsigmaTPCPr) < nsigmaMaxPr)
return true;
if (pt >= 0.5 && std::fabs(nsigmaTPCPr) < 2.0 && track.hasTOF() && std::fabs(nsigmaTOFPr) < 2.0)
if (pt >= ptThreshold && std::fabs(nsigmaTPCPr) < nsigmaMaxPr && track.hasTOF() && std::fabs(nsigmaTOFPr) < nsigmaMaxPr)
return true;
return false;
}
Expand Down Expand Up @@ -1013,7 +1027,8 @@ struct AntinucleiInJets {

if (!particle.isPhysicalPrimary())
continue;
if (particle.eta() < -0.8 || particle.eta() > 0.8 || particle.pt() < 0.1)
double minPtParticle = 0.1;
if (particle.eta() < minEta || particle.eta() > maxEta || particle.pt() < minPtParticle)
continue;

double energy = std::sqrt(particle.p() * particle.p() + MassPionCharged * MassPionCharged);
Expand Down Expand Up @@ -1068,7 +1083,8 @@ struct AntinucleiInJets {

if (!particle.isPhysicalPrimary())
continue;
if (particle.eta() < -0.8 || particle.eta() > 0.8 || particle.pt() < 0.1)
double minPtParticle = 0.1;
if (particle.eta() < minEta || particle.eta() > maxEta || particle.pt() < minPtParticle)
continue;

double deltaEtaUe1 = particle.eta() - ueAxis1.Eta();
Expand Down
Loading