Skip to content

[Common] Split PIDResponse between TPC and TOF #10119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
njacazio merged 2 commits into from
Apr 24, 2025
Merged

[Common] Split PIDResponse between TPC and TOF #10119

njacazio merged 2 commits into from
Apr 24, 2025

Conversation

@njacazio
Copy link
Collaborator

@njacazio njacazio commented Feb 21, 2025

No description provided.

@github-actions github-actions bot changed the title Split PIDResponse between TPC and TOF [Common] Split PIDResponse between TPC and TOF Feb 21, 2025
@github-actions
Copy link

github-actions bot commented Mar 24, 2025

This PR has not been updated in the last 30 days. Is it still needed? Unless further action is taken, it will be closed in 5 days.

@github-actions github-actions bot added the stale label Mar 24, 2025
@github-actions github-actions bot closed this Mar 30, 2025
@njacazio njacazio reopened this Apr 11, 2025
@njacazio njacazio marked this pull request as ready for review April 11, 2025 07:58
@njacazio njacazio requested review from a team, alibuild, ddobrigk, iarsene, jgrosseo and ktf as code owners April 11, 2025 07:58
@alibuild
Copy link
Collaborator

alibuild commented Apr 11, 2025

Error while checking build/O2Physics/o2 for 955312b at 2025-04-11 10:48:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/10119-slc9_x86-64/0/PWGHF/TableProducer/mcPidTof.cxx:840:26: error: 'packInTable' is not a member of 'o2::aod::pidutils'
/sw/SOURCES/O2Physics/10119-slc9_x86-64/0/PWGHF/TableProducer/mcPidTof.cxx:840:63: error: expected primary-expression before '>' token
/sw/SOURCES/O2Physics/10119-slc9_x86-64/0/PWGHF/TableProducer/mcPidTof.cxx:840:65: error: left operand of comma operator has no effect [-Werror=unused-value]
/sw/SOURCES/O2Physics/10119-slc9_x86-64/0/PWGHF/TableProducer/mcPidTof.cxx:848:26: error: 'packInTable' is not a member of 'o2::aod::pidutils'
/sw/SOURCES/O2Physics/10119-slc9_x86-64/0/PWGHF/TableProducer/mcPidTof.cxx:848:63: error: expected primary-expression before '>' token
/sw/SOURCES/O2Physics/10119-slc9_x86-64/0/PWGHF/TableProducer/mcPidTof.cxx:848:65: error: left operand of comma operator has no effect [-Werror=unused-value]
/sw/SOURCES/O2Physics/10119-slc9_x86-64/0/PWGHF/TableProducer/mcPidTof.cxx:856:26: error: 'packInTable' is not a member of 'o2::aod::pidutils'
/sw/SOURCES/O2Physics/10119-slc9_x86-64/0/PWGHF/TableProducer/mcPidTof.cxx:856:63: error: expected primary-expression before '>' token
/sw/SOURCES/O2Physics/10119-slc9_x86-64/0/PWGHF/TableProducer/mcPidTof.cxx:856:65: error: left operand of comma operator has no effect [-Werror=unused-value]
/sw/SOURCES/O2Physics/10119-slc9_x86-64/0/PWGHF/TableProducer/mcPidTof.cxx:978:28: error: 'packInTable' is not a member of 'o2::aod::pidutils'
/sw/SOURCES/O2Physics/10119-slc9_x86-64/0/PWGHF/TableProducer/mcPidTof.cxx:978:65: error: expected primary-expression before '>' token
/sw/SOURCES/O2Physics/10119-slc9_x86-64/0/PWGHF/TableProducer/mcPidTof.cxx:978:67: error: left operand of comma operator has no effect [-Werror=unused-value]
/sw/SOURCES/O2Physics/10119-slc9_x86-64/0/PWGHF/TableProducer/mcPidTof.cxx:988:28: error: 'packInTable' is not a member of 'o2::aod::pidutils'
/sw/SOURCES/O2Physics/10119-slc9_x86-64/0/PWGHF/TableProducer/mcPidTof.cxx:988:65: error: expected primary-expression before '>' token
/sw/SOURCES/O2Physics/10119-slc9_x86-64/0/PWGHF/TableProducer/mcPidTof.cxx:988:67: error: left operand of comma operator has no effect [-Werror=unused-value]
/sw/SOURCES/O2Physics/10119-slc9_x86-64/0/PWGHF/TableProducer/mcPidTof.cxx:998:28: error: 'packInTable' is not a member of 'o2::aod::pidutils'
/sw/SOURCES/O2Physics/10119-slc9_x86-64/0/PWGHF/TableProducer/mcPidTof.cxx:998:65: error: expected primary-expression before '>' token
/sw/SOURCES/O2Physics/10119-slc9_x86-64/0/PWGHF/TableProducer/mcPidTof.cxx:998:67: error: left operand of comma operator has no effect [-Werror=unused-value]
ninja: build stopped: subcommand failed.

Full log here.

@njacazio njacazio force-pushed the njacazio-patch-1-1-1 branch from b89dfd0 to 1f1b0e3 Compare April 11, 2025 10:06
@alibuild alibuild mentioned this pull request Apr 11, 2025
Closed
@github-actions github-actions bot removed the stale label Apr 12, 2025
@njacazio njacazio enabled auto-merge (squash) April 15, 2025 13:16
@njacazio
Copy link
Collaborator Author

njacazio commented Apr 24, 2025

Hi @ddobrigk tested on both Run2 and Run3 data, ready to merge

@njacazio njacazio merged commit 4686b14 into master Apr 24, 2025
11 of 14 checks passed
@njacazio njacazio deleted the njacazio-patch-1-1-1 branch April 24, 2025 13:59
ppoava pushed a commit to ppoava/O2Physics that referenced this pull request Apr 28, 2025
@njacazio @ppoava
[Common] Split PIDResponse between TPC and TOF (AliceO2Group#10119)
fe004e3
bghanley1995 pushed a commit to bghanley1995/O2Physics that referenced this pull request May 5, 2025
@njacazio @bghanley1995
[Common] Split PIDResponse between TPC and TOF (AliceO2Group#10119)
cdf1825
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request May 11, 2025
@njacazio @jinhyunni
[Common] Split PIDResponse between TPC and TOF (AliceO2Group#10119)
a1303db
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request May 11, 2025
@njacazio @jinhyunni
[Common] Split PIDResponse between TPC and TOF (AliceO2Group#10119)
75ec779
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request May 17, 2025
@njacazio
[Common] Split PIDResponse between TPC and TOF (AliceO2Group#10119)
68ba117
ariedel-cern pushed a commit to ariedel-cern/O2Physics that referenced this pull request May 23, 2025
@njacazio @ariedel-cern
[Common] Split PIDResponse between TPC and TOF (AliceO2Group#10119)
25a156c
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Jun 17, 2025
@njacazio @smaff92
[Common] Split PIDResponse between TPC and TOF (AliceO2Group#10119)
ae8a538
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
@njacazio @CesarOmarRA
[Common] Split PIDResponse between TPC and TOF (AliceO2Group#10119)
3bfcb0a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ddobrigk ddobrigk ddobrigk approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@jgrosseo jgrosseo Awaiting requested review from jgrosseo jgrosseo is a code owner

@iarsene iarsene Awaiting requested review from iarsene iarsene is a code owner

@ktf ktf Awaiting requested review from ktf ktf is a code owner

@alcaliva alcaliva Awaiting requested review from alcaliva

@lbariogl lbariogl Awaiting requested review from lbariogl

@chiarapinto chiarapinto Awaiting requested review from chiarapinto

@BongHwi BongHwi Awaiting requested review from BongHwi

@lbarnby lbarnby Awaiting requested review from lbarnby

@mbombara mbombara Awaiting requested review from mbombara

@iravasen iravasen Awaiting requested review from iravasen

@ChiaraDeMartin95 ChiaraDeMartin95 Awaiting requested review from ChiaraDeMartin95

@skundu692 skundu692 Awaiting requested review from skundu692

@maoyx maoyx Awaiting requested review from maoyx

@nzardosh nzardosh Awaiting requested review from nzardosh

@fjonasALICE fjonasALICE Awaiting requested review from fjonasALICE

@mfasDa mfasDa Awaiting requested review from mfasDa

@mhemmer-cern mhemmer-cern Awaiting requested review from mhemmer-cern

@pbuehler pbuehler Awaiting requested review from pbuehler

@abylinkin abylinkin Awaiting requested review from abylinkin

@rolavick rolavick Awaiting requested review from rolavick

@aalkin aalkin Awaiting requested review from aalkin

@aortizve aortizve Awaiting requested review from aortizve

@gbencedi gbencedi Awaiting requested review from gbencedi

@ercolessi ercolessi Awaiting requested review from ercolessi

@dmallick2 dmallick2 Awaiting requested review from dmallick2

@smaff92 smaff92 Awaiting requested review from smaff92

@fmazzasc fmazzasc Awaiting requested review from fmazzasc

@maciacco maciacco Awaiting requested review from maciacco

@vkucera vkucera Awaiting requested review from vkucera

@fcolamar fcolamar Awaiting requested review from fcolamar

@fgrosa fgrosa Awaiting requested review from fgrosa

@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92

@mfaggin mfaggin Awaiting requested review from mfaggin

@mmazzilli mmazzilli Awaiting requested review from mmazzilli

@deepathoms deepathoms Awaiting requested review from deepathoms

@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid

@hahassan7 hahassan7 Awaiting requested review from hahassan7

@jpxrk jpxrk Awaiting requested review from jpxrk

@apalasciano apalasciano Awaiting requested review from apalasciano

@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy

@mikesas mikesas Awaiting requested review from mikesas

@rbailhac rbailhac Awaiting requested review from rbailhac

@m-c-danisch m-c-danisch Awaiting requested review from m-c-danisch

@novitzky novitzky Awaiting requested review from novitzky

@dsekihat dsekihat Awaiting requested review from dsekihat

@ivorobye ivorobye Awaiting requested review from ivorobye

@feisenhu feisenhu Awaiting requested review from feisenhu

@lucamicheletti93 lucamicheletti93 Awaiting requested review from lucamicheletti93

@saganatt saganatt Awaiting requested review from saganatt

@victor-gonzalez victor-gonzalez Awaiting requested review from victor-gonzalez

@zchochul zchochul Awaiting requested review from zchochul

@lgraczykCern lgraczykCern Awaiting requested review from lgraczykCern

@prchakra prchakra Awaiting requested review from prchakra

@lauraser lauraser Awaiting requested review from lauraser

@ariedel-cern ariedel-cern Awaiting requested review from ariedel-cern

@otonvd otonvd Awaiting requested review from otonvd

@shouqiye shouqiye Awaiting requested review from shouqiye

@glromane glromane Awaiting requested review from glromane

@mpuccio mpuccio Awaiting requested review from mpuccio

@lietava lietava Awaiting requested review from lietava

@iouribelikov iouribelikov Awaiting requested review from iouribelikov

@ekryshen ekryshen Awaiting requested review from ekryshen

@strogolo strogolo Awaiting requested review from strogolo

@altsybee altsybee Awaiting requested review from altsybee

@chiarazampolli chiarazampolli Awaiting requested review from chiarazampolli

@catalinristea catalinristea Awaiting requested review from catalinristea

@hscheid hscheid Awaiting requested review from hscheid

Assignees

No one assigned

Labels

common datamodel

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@njacazio @alibuild @ddobrigk