[PWGUD] Switch to store SG and DG separately #20617
Annotations
10 errors and 2 notices
|
[name/configurable]:
PWGUD/TableProducer/SGCandProducer.cxx#L85
Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
|
|
[name/configurable]:
PWGUD/TableProducer/SGCandProducer.cxx#L84
Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
|
|
[name/configurable]:
PWGUD/TableProducer/SGCandProducer.cxx#L77
Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
|
|
[name/o2-task]:
PWGUD/TableProducer/SGCandProducer.cxx#L1
Specify task name only when it cannot be derived from the struct name. Only append to the default name.
|
|
[name/o2-task]:
PWGUD/TableProducer/SGCandProducer.cxx#L904
Device names mcsgcandproducer and mc-s-g-cand-producer generated from the specified task name mcsgcandproducer and from the struct name McSGCandProducer, respectively, differ in hyphenation. Consider fixing capitalisation of the struct name to Mcsgcandproducer and removing TaskName.
|
|
[name/o2-task]:
PWGUD/TableProducer/SGCandProducer.cxx#L903
Device names sgcandproducer and s-g-cand-producer generated from the specified task name sgcandproducer and from the struct name SGCandProducer, respectively, differ in hyphenation. Consider fixing capitalisation of the struct name to Sgcandproducer and removing TaskName.
|
|
[magic-number]:
PWGUD/TableProducer/SGCandProducer.cxx#L406
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
[magic-number]:
PWGUD/TableProducer/SGCandProducer.cxx#L353
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
[magic-number]:
PWGUD/TableProducer/SGCandProducer.cxx#L227
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
[magic-number]:
PWGUD/TableProducer/SGCandProducer.cxx#L224
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
O2 linter
To tolerate certain issues in a directory, add a line with the test name in "o2linter_config".
|
|
O2 linter
Exceptionally, you can disable a test for a line by adding a comment with "o2-linter: disable=" followed by the name of the test and parentheses with a reason for the exception.
|