Skip to content

Conversation

@sawenzel
Copy link
Contributor

@sawenzel sawenzel commented Oct 6, 2025

No description provided.

@sawenzel sawenzel requested a review from jackal1-66 as a code owner October 6, 2025 12:56
@github-actions
Copy link

github-actions bot commented Oct 6, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@f3sch
Copy link
Contributor

f3sch commented Oct 6, 2025

@sawenzel thanks.
this works fine for the -field arg but -bcPatternFile is explicitly not allowed in anchored to due this block

if (not args.run_anchored == True) and len(args.bcPatternFile) > 0:
GRP_TASK['cmd'] += ' --bcPatternFile ' + str(args.bcPatternFile)

Was there maybe a deeper reason to block this?

@sawenzel
Copy link
Contributor Author

sawenzel commented Oct 6, 2025

@sawenzel thanks. this works fine for the -field arg but -bcPatternFile is explicitly not allowed in anchored to due this block

if (not args.run_anchored == True) and len(args.bcPatternFile) > 0:
GRP_TASK['cmd'] += ' --bcPatternFile ' + str(args.bcPatternFile)

Was there maybe a deeper reason to block this?

No idea. I think it was more to enforce correctness of anchoring. Then I'll take this protection away.

@f3sch
Copy link
Contributor

f3sch commented Oct 6, 2025

@sawenzel thanks. this works fine for the -field arg but -bcPatternFile is explicitly not allowed in anchored to due this block

if (not args.run_anchored == True) and len(args.bcPatternFile) > 0:
GRP_TASK['cmd'] += ' --bcPatternFile ' + str(args.bcPatternFile)

Was there maybe a deeper reason to block this?

No idea. I think it was more to enforce correctness of anchoring. Then I'll take this protection away.

Thanks, with just removing the (not args.run_anchored == True) and-part I can confirm it works :)

@sawenzel sawenzel force-pushed the swenzel/option_overwrites branch from 45af240 to 02fa1bc Compare October 6, 2025 15:26
@sawenzel sawenzel merged commit a121b9d into AliceO2Group:master Oct 7, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants