TRD QC: Do not write tracklets #2144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While studying file-access graphs in O2DPG MC, I noticed that trdtracklets.root get written twice: One from the digitizer workflow and once from the TRD-DIGI-QC task. This can corrupt the processing and is probably a bug. QC should only read digits/trdtracklets. The reason appears to be the use of `o2-trd-trap-sim` as the reader command for digits and tracklets. For now, the problem can probably be avoided by using `o2-trd-trap-sim --disable-root-output true`. However, this might still create new trdtracklets in memory which should not be needed as they have been previously created during digitization. So it would be good to just use a true `o2-trd-sim-artefacts-reader` workflow or similar in the future.
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While studying file-access graphs in O2DPG MC, I noticed that trdtracklets.root get written twice: Once from the digitizer workflow and once from the TRD-DIGI-QC task. This can corrupt the processing and is probably a bug. QC should only read digits/trdtracklets.
The reason appears to be the use of
o2-trd-trap-simas the reader command for digits and tracklets.For now, the problem can probably be avoided by using
o2-trd-trap-sim --disable-root-output true.However, this might still create new trdtracklets in memory which should not be needed as they have been previously created during digitization.
So it would be good to just use a true
o2-trd-sim-artefacts-readerworkflow or similar in the future.