-
Notifications
You must be signed in to change notification settings - Fork 180
Add the userhook to the ini files used for the event pools production
#2122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
|
Hi @wuctlby many thanks! It looks good to me. |
|
ciao @fgrosa I'm having a look at it |
|
The CI is still red, so I tested it locally and this is what I found: So Only
|
Hi @jackal1-66 , thanks a lot for the checks! Indeed, there are some issues, as you were saying. And I suppose we will encounter similar problems with the |
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
|
Hi @fgrosa , @stefanopolitano , and @jackal1-66 ! In the 3 commits above, basically, I did the things below to fix the issue:
|
|
Ciao @wuctlby ,
|
|
Hi @jackal1-66 , thanks a lot for the test!
|
|
@wuctlby linked PR was merged, could you please apply the modification to the ini files? |
|
Hi @jackal1-66 , all |
|
Hello @wuctlby , the CI this time didn't timeout (the number of events patch worked) and we have a review of what went wrong in the tests. Could you please fix the last failing ones? |
|
Hi @jackal1-66 , there are 4 errors, one of which does not seem to be a bug. They are all listed below: ==> sort the vector of XXX> no obvious errors/bugs from my side ==> sort the vector of ==> fix |
|
Since |
|
Hi @stefanopolitano , could you please approve this PR? The build succeeded. But I am unable to approve my own PR. |
stefanopolitano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI @wuctlby ! Thanks for the development and for fixing the issues with the tests. Approved
Hi @fgrosa ! In this PR, I added the
usehookto theinifiles listed below:bbbarccbar