Skip to content

Take out CPV, PHS, ZDC from workflow when they are not in the run #2113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sawenzel merged 1 commit into from
Sep 9, 2025
Merged

Take out CPV, PHS, ZDC from workflow when they are not in the run #2113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 47 additions & 24 deletions MC/bin/o2dpg_sim_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,18 @@ def load_external_config(configfile):
for det in activeDetectors:
activate_detector(det)

# function to finalize detector source lists based on activeDetectors
# detector source lists are comma separated lists of DET1, DET2, DET1-DET2, ...
def cleanDetectorInputList(inputlist):
sources_list = inputlist.split(",")
# Filter the sources
filtered_sources = [
src for src in sources_list
if all(isActive(part) for part in src.split("-"))
]
# Recompose into a comma-separated string
return ",".join(filtered_sources)

if not args.with_ZDC:
# deactivate to be able to use isActive consistently for ZDC
deactivate_detector('ZDC')
Expand Down Expand Up @@ -1071,6 +1083,7 @@ def createRestDigiTask(name, det='ALLSMALLER'):
t['cmd'] = ('','ln -nfs ../bkg_Hits*.root . ;')[doembedding]
detlist = ''
detlist = ','.join(smallsensorlist)
detlist = cleanDetectorInputList(detlist)
t['cmd'] += commondigicmd + ' --onlyDet ' + detlist
t['cmd'] += ' --ccdb-tof-sa --forceSelectedDets '
t['cmd'] += (' --combine-devices ','')[args.no_combine_dpl_devices]
Expand Down Expand Up @@ -1292,7 +1305,7 @@ def getDigiTaskName(det):
#<--------- TRD global tracking
# FIXME This is so far a workaround to avoud a race condition for trdcalibratedtracklets.root
TRDTRACKINGtask2 = createTask(name='trdreco2_'+str(tf), needs=[TRDTRACKINGtask['name']], tf=tf, cwd=timeframeworkdir, lab=["RECO"], cpu='1', mem='2000')
trd_track_sources = dpl_option_from_config(anchorConfig, 'o2-trd-global-tracking', 'track-sources', default_value='TPC,ITS-TPC')
trd_track_sources = cleanDetectorInputList(dpl_option_from_config(anchorConfig, 'o2-trd-global-tracking', 'track-sources', default_value='TPC,ITS-TPC'))
TRDTRACKINGtask2['cmd'] = task_finalizer([
'${O2_ROOT}/bin/o2-trd-global-tracking',
getDPL_global_options(bigshm=True),
Expand Down Expand Up @@ -1442,7 +1455,8 @@ def getDigiTaskName(det):
getDPL_global_options(),
putConfigValues(),
('',' --disable-mc')[args.no_mc_labels]])
workflow['stages'].append(PHSRECOtask)
if isActive("PHS"):
workflow['stages'].append(PHSRECOtask)

#<--------- CPV reco workflow
CPVRECOtask = createTask(name='cpvreco_'+str(tf), needs=[getDigiTaskName("CPV")], tf=tf, cwd=timeframeworkdir, lab=["RECO"], mem='1500')
Expand All @@ -1451,7 +1465,8 @@ def getDigiTaskName(det):
getDPL_global_options(),
putConfigValues(),
('',' --disable-mc')[args.no_mc_labels]])
workflow['stages'].append(CPVRECOtask)
if isActive("CPV"):
workflow['stages'].append(CPVRECOtask)

#<--------- ZDC reco workflow
ZDCRECOtask = createTask(name='zdcreco_'+str(tf), needs=[getDigiTaskName("ZDC")], tf=tf, cwd=timeframeworkdir, lab=["RECO", "ZDC"])
Expand All @@ -1460,7 +1475,8 @@ def getDigiTaskName(det):
getDPL_global_options(),
putConfigValues(),
('',' --disable-mc')[args.no_mc_labels]])
workflow['stages'].append(ZDCRECOtask)
if isActive("ZDC"):
workflow['stages'].append(ZDCRECOtask)

## forward matching
#<--------- MCH-MID forward matching
Expand Down Expand Up @@ -1506,7 +1522,7 @@ def getDigiTaskName(det):

#<--------- HMP forward matching
hmpmatchneeds = [HMPRECOtask['name'], ITSTPCMATCHtask['name'], TOFTPCMATCHERtask['name'], TRDTRACKINGtask2['name']]
hmp_match_sources = dpl_option_from_config(anchorConfig, 'o2-hmpid-matcher-workflow', 'track-sources', default_value='ITS-TPC,ITS-TPC-TRD,TPC-TRD')
hmp_match_sources = cleanDetectorInputList(dpl_option_from_config(anchorConfig, 'o2-hmpid-matcher-workflow', 'track-sources', default_value='ITS-TPC,ITS-TPC-TRD,TPC-TRD'))
HMPMATCHtask = createTask(name='hmpmatch_'+str(tf), needs=hmpmatchneeds, tf=tf, cwd=timeframeworkdir, lab=["RECO"], mem='1000')
HMPMATCHtask['cmd'] = task_finalizer(
['${O2_ROOT}/bin/o2-hmpid-matcher-workflow',
Expand All @@ -1521,24 +1537,29 @@ def getDigiTaskName(det):
'o2-primary-vertexing-workflow',
'vertexing-sources',
default_value='ITS-TPC,TPC-TRD,ITS-TPC-TRD,TPC-TOF,ITS-TPC-TOF,TPC-TRD-TOF,ITS-TPC-TRD-TOF,MFT-MCH,MCH-MID,ITS,MFT,TPC,TOF,FT0,MID,EMC,PHS,CPV,FDD,HMP,FV0,TRD,MCH,CTP')
pvfinder_sources = cleanDetectorInputList(pvfinder_sources)

pvfinder_matching_sources = dpl_option_from_config(anchorConfig,
'o2-primary-vertexing-workflow',
'vertex-track-matching-sources',
default_value='ITS-TPC,TPC-TRD,ITS-TPC-TRD,TPC-TOF,ITS-TPC-TOF,TPC-TRD-TOF,ITS-TPC-TRD-TOF,MFT-MCH,MCH-MID,ITS,MFT,TPC,TOF,FT0,MID,EMC,PHS,CPV,FDD,HMP,FV0,TRD,MCH,CTP')
pvfinderneeds = [TRDTRACKINGtask2['name'],
FT0RECOtask['name'],
FV0RECOtask['name'],
EMCRECOtask['name'],
PHSRECOtask['name'],
CPVRECOtask['name'],
FDDRECOtask['name'],
ZDCRECOtask['name'],
HMPMATCHtask['name'],
HMPMATCHtask['name'],
ITSTPCMATCHtask['name'],
TOFTPCMATCHERtask['name'],
MFTMCHMATCHtask['name'],
pvfinder_matching_sources = cleanDetectorInputList(pvfinder_matching_sources)

pvfinderneeds = [TRDTRACKINGtask2['name'],
FT0RECOtask['name'],
FV0RECOtask['name'],
EMCRECOtask['name'],
PHSRECOtask['name'] if isActive("PHS") else None,
CPVRECOtask['name'] if isActive("CPV") else None,
FDDRECOtask['name'],
ZDCRECOtask['name'] if isActive("ZDC") else None,
HMPMATCHtask['name'],
HMPMATCHtask['name'],
ITSTPCMATCHtask['name'],
TOFTPCMATCHERtask['name'],
MFTMCHMATCHtask['name'],
MCHMIDMATCHtask['name']]
pvfinderneeds = [ p for p in pvfinderneeds if p != None ]

PVFINDERtask = createTask(name='pvfinder_'+str(tf), needs=pvfinderneeds, tf=tf, cwd=timeframeworkdir, lab=["RECO"], cpu=NWORKERS_TF, mem='4000')
PVFINDERtask['cmd'] = task_finalizer(
Expand Down Expand Up @@ -1569,6 +1590,7 @@ def getDigiTaskName(det):
'o2-primary-vertexing-workflow',
'vertex-track-matching-sources',
default_value='ITS-TPC,TPC-TRD,ITS-TPC-TRD,TPC-TOF,ITS-TPC-TOF,TPC-TRD-TOF,ITS-TPC-TRD-TOF,MFT-MCH,MCH-MID,ITS,MFT,TPC,TOF,FT0,MID,EMC,PHS,CPV,ZDC,FDD,HMP,FV0,TRD,MCH,CTP')
svfinder_sources = cleanDetectorInputList(svfinder_sources)
SVFINDERtask = createTask(name='svfinder_'+str(tf), needs=[PVFINDERtask['name'], FT0FV0EMCCTPDIGItask['name']], tf=tf, cwd=timeframeworkdir, lab=["RECO"], cpu=svfinder_cpu, mem='5000')
SVFINDERtask['cmd'] = task_finalizer(
[ '${O2_ROOT}/bin/o2-secondary-vertexing-workflow',
Expand All @@ -1588,6 +1610,7 @@ def getDigiTaskName(det):
# TODO This needs further refinement, sources and dependencies should be constructed dynamically
aod_info_souces_default = 'ITS-TPC,TPC-TRD,ITS-TPC-TRD,TPC-TOF,ITS-TPC-TOF,TPC-TRD-TOF,ITS-TPC-TRD-TOF,MFT-MCH,MCH-MID,ITS,MFT,TPC,TOF,FT0,MID,EMC,PHS,CPV,ZDC,FDD,HMP,FV0,TRD,MCH,CTP'
aodinfosources = dpl_option_from_config(anchorConfig, 'o2-aod-producer-workflow', 'info-sources', default_value=aod_info_souces_default)
aodinfosources = cleanDetectorInputList(aodinfosources)
aodneeds = [PVFINDERtask['name'], SVFINDERtask['name']]

if usebkgcache:
Expand Down Expand Up @@ -1641,20 +1664,20 @@ def getDigiTaskName(det):
print ("Adding TPC residuals extraction and aggregation")

#<------------- TPC residuals extraction
scdcalib_vertex_sources = dpl_option_from_config(anchorConfig,
scdcalib_vertex_sources = cleanDetectorInputList(dpl_option_from_config(anchorConfig,
'o2-tpc-scdcalib-interpolation-workflow',
'vtx-sources',
default_value='ITS-TPC,TPC-TRD,ITS-TPC-TRD,TPC-TOF,ITS-TPC-TOF,TPC-TRD-TOF,ITS-TPC-TRD-TOF,MFT-MCH,MCH-MID,ITS,MFT,TPC,TOF,FT0,MID,EMC,PHS,CPV,FDD,HMP,FV0,TRD,MCH,CTP')
default_value='ITS-TPC,TPC-TRD,ITS-TPC-TRD,TPC-TOF,ITS-TPC-TOF,TPC-TRD-TOF,ITS-TPC-TRD-TOF,MFT-MCH,MCH-MID,ITS,MFT,TPC,TOF,FT0,MID,EMC,PHS,CPV,FDD,HMP,FV0,TRD,MCH,CTP'))

scdcalib_track_sources = dpl_option_from_config(anchorConfig,
scdcalib_track_sources = cleanDetectorInputList(dpl_option_from_config(anchorConfig,
'o2-tpc-scdcalib-interpolation-workflow',
'tracking-sources',
default_value='ITS-TPC,TPC-TRD,ITS-TPC-TRD,TPC-TOF,ITS-TPC-TOF,TPC-TRD-TOF,ITS-TPC-TRD-TOF,MFT-MCH,MCH-MID,ITS,MFT,TPC,TOF,FT0,MID,EMC,PHS,CPV,FDD,HMP,FV0,TRD,MCH,CTP')
default_value='ITS-TPC,TPC-TRD,ITS-TPC-TRD,TPC-TOF,ITS-TPC-TOF,TPC-TRD-TOF,ITS-TPC-TRD-TOF,MFT-MCH,MCH-MID,ITS,MFT,TPC,TOF,FT0,MID,EMC,PHS,CPV,FDD,HMP,FV0,TRD,MCH,CTP'))

scdcalib_track_extraction = dpl_option_from_config(anchorConfig,
scdcalib_track_extraction = cleanDetectorInputList(dpl_option_from_config(anchorConfig,
'o2-tpc-scdcalib-interpolation-workflow',
'tracking-sources-map-extraction',
default_value='ITS-TPC')
default_value='ITS-TPC'))

SCDCALIBtask = createTask(name='scdcalib_'+str(tf), needs=[PVFINDERtask['name']], tf=tf, cwd=timeframeworkdir, lab=["CALIB"], mem='4000')
SCDCALIBtask['cmd'] = task_finalizer(
Expand Down