Skip to content

Conversation

@jackal1-66
Copy link
Collaborator

Changed number of QED events based on https://its.cern.ch/jira/browse/O2-5861

@github-actions
Copy link

github-actions bot commented Aug 5, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@jackal1-66
Copy link
Collaborator Author

@shahor02 could you take a look? It's a simple fix

Copy link
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jackal1-66 , I would say factor 0.3 is a strict minimum, could you change the factor to 0.6 and cap the NEventsQED to e.g. 10000?

@sawenzel
Copy link
Contributor

sawenzel commented Aug 5, 2025

Thanks @jackal1-66 , I would say factor 0.3 is a strict minimum, could you change the factor to 0.6 and cap the NEventsQED to e.g. 10000?

@shahor02 : But if we cap to 10000, no improvement will be made. We are already at 10000 standard.

@shahor02
Copy link
Collaborator

shahor02 commented Aug 5, 2025

sorry, used wrong expression, surely, I meant to floor it to 10k.

@jackal1-66
Copy link
Collaborator Author

Thanks @jackal1-66 , I would say factor 0.3 is a strict minimum, could you change the factor to 0.6 and cap the NEventsQED to e.g. 10000?

Done and added the floor to 10000

@sawenzel sawenzel merged commit 7287424 into AliceO2Group:master Aug 5, 2025
5 of 7 checks passed
@jackal1-66 jackal1-66 deleted the qednev branch October 17, 2025 11:33
@jackal1-66 jackal1-66 restored the qednev branch October 17, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants