Skip to content

Conversation

@chengtt0406
Copy link
Contributor

No description provided.

@chengtt0406 chengtt0406 requested a review from a team as a code owner July 17, 2025 08:06
@github-actions
Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@stefanopolitano
Copy link
Contributor

Hi @chengtt0406! Thanks for the development! I don't have any comment regarding the changes from this PR, just remember to add the script for testing the new .ini files (you can have a look to the one used for the OmegaNoDecay case or to the other scripts in the same folder as an example)

@chengtt0406 chengtt0406 force-pushed the master branch 3 times, most recently from fd3257e to 94997e4 Compare July 18, 2025 07:32
@chengtt0406
Copy link
Contributor Author

chengtt0406 commented Jul 18, 2025

Hi @chengtt0406! Thanks for the development! I don't have any comment regarding the changes from this PR, just remember to add the script for testing the new .ini files (you can have a look to the one used for the OmegaNoDecay case or to the other scripts in the same folder as an example)

Hi @stefanopolitano , thanks for your comment, which was addressed in the new push '[94997e4]'.

Additionally, files for pp reference event pools for Xic0, Xic+, and Omegac0 are also added, which are discussed in the email thread.

@stefanopolitano
Copy link
Contributor

stefanopolitano commented Jul 18, 2025

Hi @chengtt0406! Thanks for implementing the comments! Everything looks good to me. Although, now that you split the .ini files of Omegac and Xic you have 8 different files and each of them requires a dedicated test

@chengtt0406
Copy link
Contributor Author

Hi @stefanopolitano, thanks for your comments. All the tests were done and succeeded, I was closely discussing with Fabrizio. After separating the ini file for each case, I forgot to add the corresponding scripts for them in the test folder, which caused the build fail. Now they are added. Sorry for the mistake.
PS: As I know that Fabrizio is on vacation, it would be nice if you could approve this PR. Thanks for your time.

@chengtt0406
Copy link
Contributor Author

Hi @chengtt0406! Thanks for implementing the comments! Everything looks good to me. Although, now that you split the .ini files of Omegac and Xic you have 8 different files and each of them requires a dedicated test

Here are the paths of the test results for each file, in case you would like to have a look:

  1. /alice/cern.ch/user/t/ticheng/selfjobs/EvtPool_ccbar_pp_ref_XiC-20250718-114311/001
  2. /alice/cern.ch/user/t/ticheng/selfjobs/EvtPool_ccbar_pp_ref_XiCplus-20250718-121316/001
  3. /alice/cern.ch/user/t/ticheng/selfjobs/EvtPool_ccbar_pp_ref_OmegaC-20250718-132036/001
  4. /alice/cern.ch/user/t/ticheng/selfjobs/EvtPool_bbbar_pp_ref_XiC-20250718-120556/001
  5. /alice/cern.ch/user/t/ticheng/selfjobs/EvtPool_bbbar_pp_ref_XiCplus-20250718-122420/001
  6. /alice/cern.ch/user/t/ticheng/selfjobs/EvtPool_bbbar_pp_ref_OmegaC-20250718-131204/001
  7. /alice/cern.ch/user/t/ticheng/selfjobs/EventPools_bbbar_XiC-20250706-145428/
  8. /alice/cern.ch/user/t/ticheng/selfjobs/TianTest_evtpool_ccbar_Xic-20250715-135807

@stefanopolitano
Copy link
Contributor

Hi @chengtt0406 ! Thanks a lot for implementing the comments. That's all from my side!

@stefanopolitano stefanopolitano merged commit 3448606 into AliceO2Group:master Jul 20, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants