Skip to content

Conversation

@sawenzel
Copy link
Contributor

This commit refactors the transfer of anchoring configuration from async-reco scripts into the MC pipeline, addressing O2-5011 by replacing the previous whitelisting mechanism with a blacklisting approach.

In addition, it introduces broader configuration/customization support: users can now inject arbitrary command-line options into any task via a customize.json file, reducing the need to edit workflow scripts.

For example:
{
"ConfigParams": {
"EMCSimParam": {
"mBusyTime": "11.11"
}
},
"Executables": {
"o2-ft0-reco-workflow": {
"filtered": {
"--my-custom-option": "foo"
}
},
"ft0fv0emcctp_digi": {
"filtered": {
"--another-custom-option": "baz"
}
}
}
}

This allows for flexible injection of both configKeyValues and CLI options via o2dpg_sim_workflow.py --overwrite-config customize.json.

This commit refactors the transfer of anchoring configuration from
async-reco scripts into the MC pipeline, addressing O2-5011 by
replacing the previous whitelisting mechanism with a blacklisting approach.

In addition, it introduces broader configuration/customization support:
users can now inject arbitrary command-line options into any task
via a `customize.json` file, reducing the need to edit workflow scripts.

For example:
{
  "ConfigParams": {
    "EMCSimParam": {
      "mBusyTime": "11.11"
    }
  },
  "Executables": {
    "o2-ft0-reco-workflow": {
      "filtered": {
        "--my-custom-option": "foo"
      }
    },
    "ft0fv0emcctp_digi": {
      "filtered": {
        "--another-custom-option": "baz"
      }
    }
  }
}

This allows for flexible injection of both configKeyValues and CLI options
via `o2dpg_sim_workflow.py --overwrite-config customize.json`.
This task seems no longer needed.
@github-actions
Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@sawenzel
Copy link
Contributor Author

@shahor02 : Proposal for the blacklisting refactor. We will now pickup things like --trackqc-fraction for the aod-converter from the async workflows and in addition we gain a much better configurability overall.

We still need to do some final adjustments, proper testing, and the treatment for TPC distortions. For now WIP.

@sawenzel sawenzel marked this pull request as draft April 16, 2025 12:54
@shahor02
Copy link
Collaborator

@sawenzel thanks, looks nice! (did not dive into the implementation details)

@sawenzel sawenzel force-pushed the swenzel/config-refactor branch 3 times, most recently from 807d610 to b0255d0 Compare April 23, 2025 12:31
@sawenzel sawenzel marked this pull request as ready for review April 23, 2025 12:32
@sawenzel sawenzel changed the title WIP: Refactor of anchor configuration logic Refactor of anchor configuration logic Apr 23, 2025
@sawenzel sawenzel merged commit 7b07caf into AliceO2Group:master Apr 23, 2025
7 checks passed
ALIEN_JDL_LPMPRODUCTIONTAG=$ALIEN_JDL_LPMANCHORPRODUCTION

if [[ $ALIEN_JDL_ANCHOR_SIM_OPTIONS == *"--tpc-distortion-type 2"* ]]; then
export O2DPG_ENABLE_TPC_DISTORTIONS=ON
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sawenzel suppression of this line leads to disabling corrections in the reconstruction even if distortions were used in the digitization (this happened in the recent test of Mesut LHC25b8a_default_v4, while in LHC25b8a_default_v3 they were OK).
I remember you did something else to detect distortion used in the digi. but I don't remember what and it seems it did not work. Shall we simply restore this line?

sawenzel added a commit to sawenzel/O2DPG that referenced this pull request May 20, 2025
A bug for TPC distortion treatment crept in with the refactor of
AliceO2Group#1966

This commit fixes it.
sawenzel added a commit to sawenzel/O2DPG that referenced this pull request May 20, 2025
A bug for TPC distortion treatment crept in with the refactor of
AliceO2Group#1966

This commit fixes it.
sawenzel added a commit that referenced this pull request May 20, 2025
A bug for TPC distortion treatment crept in with the refactor of
#1966

This commit fixes it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants