Skip to content

Conversation

@f3sch
Copy link
Contributor

@f3sch f3sch commented Mar 24, 2025

  • minPtITSCut,minPtCut to 0.1 below that we are dominated by fakes
  • maxPtCut to 20 beyond that we do not check (also this sets the scale of the histograms)

@github-actions
Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@f3sch
Copy link
Contributor Author

f3sch commented Mar 24, 2025

+async-label async-2023-PbPb-apass5, async-2024-ppRef-apass1, async-2024-PbPb-apass2

@github-actions
Copy link

Hi @f3sch, due to your association, labels are not added automatically. Probably, this is your first contribution. Please contact one of the reviewers or code owners.

1 similar comment
@github-actions
Copy link

Hi @f3sch, due to your association, labels are not added automatically. Probably, this is your first contribution. Please contact one of the reviewers or code owners.

@chiarazampolli
Copy link
Collaborator

+async-label async-2023-PbPb-apass5, async-2024-ppRef-apass1, async-2024-PbPb-apass2

@chiarazampolli
Copy link
Collaborator

@f3sch , maybe this is your first contribution to O2DPG, so I added the labels for you.

@f3sch
Copy link
Contributor Author

f3sch commented Mar 24, 2025

@chiarazampolli yes, it is. Thank you! It still needs some security approval for it to run the tests.

@chiarazampolli
Copy link
Collaborator

Hello @f3sch ,
I see that you move the eta cut. There will be plots that are 2D where you can make a tighter cut a priori, but others not, right? I am mentioning it since for now the TPC corrections are limited to 0.9.
Chiara

@f3sch
Copy link
Contributor Author

f3sch commented Mar 25, 2025

I was under the impression that TPC asked that the checks from now on should be extended to 1.4 since they extended the maps?

@chiarazampolli
Copy link
Collaborator

In principle, this is the plan, yes. But I don't know if this was fully validated yet. I can ask.

@chiarazampolli
Copy link
Collaborator

As agreed with @f3sch , for now we remove the enlarging of the eta cut, till it is fully validated by the TPC team.

@chiarazampolli chiarazampolli merged commit 6c569d5 into AliceO2Group:master Mar 25, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants