Skip to content

Conversation

@jesgum
Copy link
Contributor

@jesgum jesgum commented Mar 13, 2025

Add xi injector for pp and PbPb for the on-the-fly studies on hyperloop

@github-actions
Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@jesgum
Copy link
Contributor Author

jesgum commented Mar 14, 2025

Hi @sawenzel @jackal1-66, could you please have a look and merge if possible? Many thanks!

@jackal1-66
Copy link
Collaborator

Hi @jesgum could you implement a valid test for this external generator? Something that checks the original collision system and checks that Xi is properly generated would be enough for example.

@jesgum
Copy link
Contributor Author

jesgum commented Mar 14, 2025

Thanks for the reply @jackal1-66! I have added a test for the two ini-files, could you please have a look check if this is what you had in mind? Thanks!

@jackal1-66
Copy link
Collaborator

The test seems to be fine, but we have an error in the CI, could you please check?

@jackal1-66
Copy link
Collaborator

Seems to be failing still

@jesgum
Copy link
Contributor Author

jesgum commented Mar 14, 2025

Looks like it's ok now

@jackal1-66 jackal1-66 merged commit 3c185dc into AliceO2Group:master Mar 14, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants