Workaround crash in TPC digitization #1923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TPC digitization currently crashes when multiple workers try to load FEEConfig via TPC/Config/RunInfoV2. Recently the TPC code was changed to use this redirecting object. The hypothesis is that there is a problem in the CcdbApi when using CCDB redirects which is bypassing semaphore syncronization of CCDB loads. This leads to race conditions and corrupted CCDB snapshots. This commit reduces such a race condition by pre-downloading TPC/Config/RunInfoV2 before launching multi-process TPC digitization procedures. We can take the change back once a proper fix is available in O2-CCDB.
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TPC digitization currently crashes when multiple workers try to load FEEConfig via TPC/Config/RunInfoV2.
Recently the TPC code was changed to use this redirecting object. The hypothesis is that there is a problem in the CcdbApi when using CCDB redirects which is bypassing semaphore syncronization of CCDB loads. This leads to race conditions and corrupted CCDB snapshots.
This commit reduces such a race condition by pre-downloading TPC/Config/RunInfoV2 before launching multi-process TPC digitization procedures.
We can take the change back once a proper fix is available in O2-CCDB.