Skip to content

Conversation

@dstocco
Copy link
Contributor

@dstocco dstocco commented Feb 4, 2025

This PR allows for a better comparison between data and MC.
The masks are applied during reconstruction for both data and MC. But data are already masked since this is done at the electronics level, while MC is masked only during reconstruction.
So far the QC checked for digits before the masks are applied, which leads to a difference between data and MC.
This PR introduces a check on digits after the masks are applied, so that we can compare apples to apples.

@github-actions
Copy link

github-actions bot commented Feb 4, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@lucaquaglia15
Copy link
Contributor

Hello, is there any news on this PR? Thanks from the MID aQC team ;)

@lmassacr
Copy link
Contributor

Hi all,
It seems the failure of the CI is unrelated to the code, but to a token issue. Can this PR be approved and merged?

@sawenzel sawenzel merged commit 48835e7 into AliceO2Group:master Feb 26, 2025
7 of 8 checks passed
@dstocco dstocco deleted the filtered_digits branch February 26, 2025 14:58
@alcaliva alcaliva self-requested a review July 28, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants