Fix injection gap math #1859
Merged
Fix injection gap math #1859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change introduced in AliceO2Group#1431 had the side effect that no signal events were present in recent productions using this generator, as for operator precedence one could never satisfy the condition of the if regulating the generation of signal events.
mpuccio
requested review from
a team,
benedikt-voelkel,
chiarazampolli and
sawenzel
as code owners
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
Collaborator
|
Thanks, nice catch! |
skundu692
approved these changes
Dec 20, 2024
Contributor
|
You may also take a look at the novel hybrid event generator (see for instance https://github.com/AliceO2Group/AliceO2/blob/dev/run/SimExamples/Hybrid/hybridconfig.json) which allows to pick events from multiple different generator instances in certain sequences. |
alcaliva
pushed a commit
that referenced
this pull request
Jan 22, 2025
* Fix injection gap math The change introduced in #1431 had the side effect that no signal events were present in recent productions using this generator, as for operator precedence one could never satisfy the condition of the if regulating the generation of signal events. * Further simplify the code (cherry picked from commit c23cfd2)
alcaliva
pushed a commit
that referenced
this pull request
Jan 23, 2025
* Fix injection gap math The change introduced in #1431 had the side effect that no signal events were present in recent productions using this generator, as for operator precedence one could never satisfy the condition of the if regulating the generation of signal events. * Further simplify the code (cherry picked from commit c23cfd2)
alcaliva
pushed a commit
that referenced
this pull request
Jan 28, 2025
* Fix injection gap math The change introduced in #1431 had the side effect that no signal events were present in recent productions using this generator, as for operator precedence one could never satisfy the condition of the if regulating the generation of signal events. * Further simplify the code (cherry picked from commit c23cfd2)
alcaliva
pushed a commit
that referenced
this pull request
Feb 3, 2025
* Fix injection gap math The change introduced in #1431 had the side effect that no signal events were present in recent productions using this generator, as for operator precedence one could never satisfy the condition of the if regulating the generation of signal events. * Further simplify the code (cherry picked from commit c23cfd2)
alcaliva
pushed a commit
that referenced
this pull request
Feb 4, 2025
* Fix injection gap math The change introduced in #1431 had the side effect that no signal events were present in recent productions using this generator, as for operator precedence one could never satisfy the condition of the if regulating the generation of signal events. * Further simplify the code (cherry picked from commit c23cfd2)
alcaliva
pushed a commit
that referenced
this pull request
Feb 17, 2025
* Fix injection gap math The change introduced in #1431 had the side effect that no signal events were present in recent productions using this generator, as for operator precedence one could never satisfy the condition of the if regulating the generation of signal events. * Further simplify the code (cherry picked from commit c23cfd2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change introduced in #1431 had the side effect that no signal events were present in recent productions using this generator, as for operator precedence one could never satisfy the condition of the if regulating the generation of signal events.
@njacazio @ddobrigk