remove lines which inhibit transport at large eta

[ffionda]

No description provided.

[github-actions]

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

[sawenzel]

The CI seems to fail for this generator (GeneratorHF_bbbarToBplus_midy_triggerGap.ini). @jackal1-66 @ffionda: Could you take a look if this is reproducible locally?

[jackal1-66]

It fails also on LXPLUS. Log shows:

In file included from input_line_143:1:
/tmp/mgiacalo/O2DPG/MC/config/PWGDQ/external/generator/generator_pythia8_NonPromptSignals_gaptriggered_dq.C:143:3: error: reference to 'Pythia' is ambiguous
  Pythia pythiaMBgen; // minimum bias event  
  ^
/cvmfs/alice.cern.ch/el9-x86_64/Packages/ROOT/v6-32-06-alice1-7/include/TPythia8.h:72:7: note: candidate found by name lookup is 'Pythia'
class Pythia;
      ^
/local/workspace/DailyBuilds/DailyO2Physics-slc9/daily-tags.7JMUWCa2YN/slc9_x86-64/pythia/v8311-20/include/Pythia8/Pythia.h:71:7: note: candidate found by name lookup is 'Pythia8
::Pythia'
class Pythia {
      ^
In file included from input_line_143:1:
/tmp/mgiacalo/O2DPG/MC/config/PWGDQ/external/generator/generator_pythia8_NonPromptSignals_gaptriggered_dq.C:143:10: error: field has incomplete type 'Pythia'
  Pythia pythiaMBgen; // minimum bias event  
         ^
/cvmfs/alice.cern.ch/el9-x86_64/Packages/ROOT/v6-32-06-alice1-7/include/TPythia8.h:72:7: note: forward declaration of 'Pythia'
class Pythia;
      ^
In file included from input_line_143:1:
/tmp/mgiacalo/O2DPG/MC/config/PWGDQ/external/generator/generator_pythia8_NonPromptSignals_gaptriggered_dq.C:76:36: error: cannot initialize object parameter of type 'o2::eventgen
::GeneratorPythia8' with an expression of type 'o2::eventgen::GeneratorPythia8NonPromptInjectedGapTriggeredDQ'
         genOk = GeneratorPythia8::generateEvent(); 
                                   ^~~~~~~~~~~~~
/tmp/mgiacalo/O2DPG/MC/config/PWGDQ/external/generator/generator_pythia8_NonPromptSignals_gaptriggered_dq.C:96:20: error: cannot initialize object parameter of type 'o2::eventgen
::GeneratorPythia8' with an expression of type 'o2::eventgen::GeneratorPythia8NonPromptInjectedGapTriggeredDQ'
        GeneratorPythia8::Init();
                          ^~~~
/tmp/mgiacalo/O2DPG/MC/config/PWGDQ/external/generator/generator_pythia8_NonPromptSignals_gaptriggered_dq.C:190:44: warning: format specifies type 'int' but the argument has type
 'unsigned long long' [-Wformat]
  gen->readString(Form("Random:seed = %d", random_value % 900000001));
                                      ~~   ^~~~~~~~~~~~~~~~~~~~~~~~
                                      %llu
/tmp/mgiacalo/O2DPG/MC/config/PWGDQ/external/generator/generator_pythia8_NonPromptSignals_gaptriggered_dq.C:202:3: error: cannot initialize object parameter of type 'o2::eventgen
::GeneratorPythia8NonPromptInjectedGapTriggeredDQ' with an expression of type 'o2::eventgen::GeneratorEvtGen<o2::eventgen::GeneratorPythia8NonPromptInjectedGapTriggeredDQ>'
  gen->setRapidity(rapidityMin, rapidityMax);
  ^~~
/tmp/mgiacalo/O2DPG/MC/config/PWGDQ/external/generator/generator_pythia8_NonPromptSignals_gaptriggered_dq.C:203:3: error: cannot initialize object parameter of type 'o2::eventgen
::GeneratorPythia8NonPromptInjectedGapTriggeredDQ' with an expression of type 'o2::eventgen::GeneratorEvtGen<o2::eventgen::GeneratorPythia8NonPromptInjectedGapTriggeredDQ>'
  gen->setPDG(5);
  ^~~
/tmp/mgiacalo/O2DPG/MC/config/PWGDQ/external/generator/generator_pythia8_NonPromptSignals_gaptriggered_dq.C:204:3: error: cannot initialize object parameter of type 'o2::eventgen
::GeneratorPythia8NonPromptInjectedGapTriggeredDQ' with an expression of type 'o2::eventgen::GeneratorEvtGen<o2::eventgen::GeneratorPythia8NonPromptInjectedGapTriggeredDQ>'
  gen->setRapidityHadron(rapidityMin,rapidityMax);
  ^~~
/tmp/mgiacalo/O2DPG/MC/config/PWGDQ/external/generator/generator_pythia8_NonPromptSignals_gaptriggered_dq.C:205:3: error: cannot initialize object parameter of type 'o2::eventgen
::GeneratorPythia8NonPromptInjectedGapTriggeredDQ' with an expression of type 'o2::eventgen::GeneratorEvtGen<o2::eventgen::GeneratorPythia8NonPromptInjectedGapTriggeredDQ>'
  gen->setHadronMultiplicity(1);
  ^~~
/tmp/mgiacalo/O2DPG/MC/config/PWGDQ/external/generator/generator_pythia8_NonPromptSignals_gaptriggered_dq.C:207:3: error: cannot initialize object parameter of type 'o2::eventgen
::GeneratorPythia8' with an expression of type 'o2::eventgen::GeneratorEvtGen<o2::eventgen::GeneratorPythia8NonPromptInjectedGapTriggeredDQ>'
  gen->readFile(pathO2table.Data());
  ^~~
/tmp/mgiacalo/O2DPG/MC/config/PWGDQ/external/generator/generator_pythia8_NonPromptSignals_gaptriggered_dq.C:208:3: error: cannot initialize object parameter of type 'o2::eventgen
::GeneratorPythia8NonPromptInjectedGapTriggeredDQ' with an expression of type 'o2::eventgen::GeneratorEvtGen<o2::eventgen::GeneratorPythia8NonPromptInjectedGapTriggeredDQ>'
  gen->setConfigMBdecays(pathO2table);
  ^~~
/tmp/mgiacalo/O2DPG/MC/config/PWGDQ/external/generator/generator_pythia8_NonPromptSignals_gaptriggered_dq.C:209:3: error: cannot initialize object parameter of type 'o2::eventgen
::GeneratorPythia8NonPromptInjectedGapTriggeredDQ' with an expression of type 'o2::eventgen::GeneratorEvtGen<o2::eventgen::GeneratorPythia8NonPromptInjectedGapTriggeredDQ>'
  gen->setVerbose(verbose);
  ^~~
/tmp/mgiacalo/O2DPG/MC/config/PWGDQ/external/generator/generator_pythia8_NonPromptSignals_gaptriggered_dq.C:218:5: error: cannot initialize object parameter of type 'o2::eventgen
::GeneratorPythia8NonPromptInjectedGapTriggeredDQ' with an expression of type 'o2::eventgen::GeneratorEvtGen<o2::eventgen::GeneratorPythia8NonPromptInjectedGapTriggeredDQ>'
    gen->addHadronPDGs(std::stoi(spdg));
    ^~~
/tmp/mgiacalo/O2DPG/MC/config/PWGDQ/external/generator/generator_pythia8_NonPromptSignals_gaptriggered_dq.C:223:3: error: cannot initialize object parameter of type 'o2::eventgen
::GeneratorPythia8' with an expression of type 'o2::eventgen::GeneratorEvtGen<o2::eventgen::GeneratorPythia8NonPromptInjectedGapTriggeredDQ>'
  gen->readString("Random:setSeed on");
  ^~~
/tmp/mgiacalo/O2DPG/MC/config/PWGDQ/external/generator/generator_pythia8_NonPromptSignals_gaptriggered_dq.C:228:44: warning: format specifies type 'int' but the argument has type
 'unsigned long long' [-Wformat]
  gen->readString(Form("Random:seed = %d", random_value % 900000001));
                                      ~~   ^~~~~~~~~~~~~~~~~~~~~~~~
                                      %llu
/tmp/mgiacalo/O2DPG/MC/config/PWGDQ/external/generator/generator_pythia8_NonPromptSignals_gaptriggered_dq.C:228:3: error: cannot initialize object parameter of type 'o2::eventgen
::GeneratorPythia8' with an expression of type 'o2::eventgen::GeneratorEvtGen<o2::eventgen::GeneratorPythia8NonPromptInjectedGapTriggeredDQ>'
  gen->readString(Form("Random:seed = %d", random_value % 900000001));
  ^~~
/tmp/mgiacalo/O2DPG/MC/config/PWGDQ/external/generator/generator_pythia8_NonPromptSignals_gaptriggered_dq.C:233:10: error: cannot initialize return object of type 'FairGenerator 
*' with an lvalue of type 'o2::eventgen::GeneratorEvtGen<o2::eventgen::GeneratorPythia8NonPromptInjectedGapTriggeredDQ> *'
  return gen;
         ^~~
/tmp/mgiacalo/O2DPG/MC/config/PWGDQ/external/generator/generator_pythia8_NonPromptSignals_gaptriggered_dq.C:240:3: error: cannot initialize object parameter of type 'o2::eventgen
::GeneratorPythia8NonPromptInjectedGapTriggeredDQ' with an expression of type 'o2::eventgen::GeneratorEvtGen<o2::eventgen::GeneratorPythia8NonPromptInjectedGapTriggeredDQ>'
  gen->setRapidity(rapidityMin, rapidityMax);
  ^~~
/tmp/mgiacalo/O2DPG/MC/config/PWGDQ/external/generator/generator_pythia8_NonPromptSignals_gaptriggered_dq.C:241:3: error: cannot initialize object parameter of type 'o2::eventgen
::GeneratorPythia8NonPromptInjectedGapTriggeredDQ' with an expression of type 'o2::eventgen::GeneratorEvtGen<o2::eventgen::GeneratorPythia8NonPromptInjectedGapTriggeredDQ>'
  gen->setPDG(5);
  ^~~
/tmp/mgiacalo/O2DPG/MC/config/PWGDQ/external/generator/generator_pythia8_NonPromptSignals_gaptriggered_dq.C:242:3: error: cannot initialize object parameter of type 'o2::eventgen
::GeneratorPythia8NonPromptInjectedGapTriggeredDQ' with an expression of type 'o2::eventgen::GeneratorEvtGen<o2::eventgen::GeneratorPythia8NonPromptInjectedGapTriggeredDQ>'
  gen->addHadronPDGs(521);
  ^~~
/tmp/mgiacalo/O2DPG/MC/config/PWGDQ/external/generator/generator_pythia8_NonPromptSignals_gaptriggered_dq.C:243:3: error: cannot initialize object parameter of type 'o2::eventgen
::GeneratorPythia8NonPromptInjectedGapTriggeredDQ' with an expression of type 'o2::eventgen::GeneratorEvtGen<o2::eventgen::GeneratorPythia8NonPromptInjectedGapTriggeredDQ>'
  gen->setRapidityHadron(rapidityMin,rapidityMax);
  ^~~
/tmp/mgiacalo/O2DPG/MC/config/PWGDQ/external/generator/generator_pythia8_NonPromptSignals_gaptriggered_dq.C:244:3: error: cannot initialize object parameter of type 'o2::eventgen
::GeneratorPythia8NonPromptInjectedGapTriggeredDQ' with an expression of type 'o2::eventgen::GeneratorEvtGen<o2::eventgen::GeneratorPythia8NonPromptInjectedGapTriggeredDQ>'
  gen->setHadronMultiplicity(2);
  ^~~
fatal error: too many errors emitted, stopping now [-ferror-limit=]

[ffionda]

Thanks @sawenzel and @jackal1-66, I'm investigating on lxplus, but I think the issue is not related to this PR. It appears for me on lxplus moving from O2sim::v20240703-1 to O2sim::v20240704-1 versions. I'll continue to check, I don't know if you have any hint. Thank you

[ffionda]

Dear @sawenzel, I tried to reproduce the error locally, and I see that the ambiguity pointed by the error message can be solved by the following change:

---

@@ -9,7 +9,6 @@ R__ADD_INCLUDE_PATH($O2DPG_ROOT/MC/config/PWGDQ/EvtGen)
#include

using namespace o2::eventgen;
-using namespace Pythia8;

namespace o2
{
@@ -140,7 +139,7 @@ Pythia8::Event mOutputEvent;
// Control gap-triggering
unsigned long long mGeneratedEvents;
int mInverseTriggerRatio;
-Pythia pythiaMBgen; // minimum bias event
+Pythia8::Pythia pythiaMBgen; // minimum bias event
TString mConfigMBdecays;
int mPDG;
std::vector mHadronsPDGs;

---

Do you think this would be fine ? If you agree, I will update this PR accordingly. Thank you

[sawenzel]

@ffionda : I think this change would be appreciated and a good idea.

[ffionda]

@sawenzel: Thanks for confirming. I would like to request to include this PR in the production software with the following labels:
+async-label async-2022-pp-apass7, async-2023-pp-apass4, async-2024-pp-apass1 (I don't have the permissions to change this in the page). Thank you.

[sawenzel]

@ffionda : Thanks for the fix!

Concerning the tagging: Maybe this is no longer necessary at all. We have now the possibility to load PWG generator configs from an arbitrary tag as outlined in this ticket https://its.cern.ch/jira/browse/O2-5366.

The production simply needs to specify a JDL variable ALIEN_JDL_O2DPG_MC_CONFIG_ROOT to point to the correct path on CVFMS. (Or directly set O2DPG_MC_CONFIG_ROOT in small user studies).

[ffionda]

@sawenzel: thanks for the input, I think you are right. I tried to set ALIEN_JDL_O2DPG_MC_CONFIG_ROOT (considering the daily O2DPG tag with the fix applied) in the JDL and it seems it works correctly (output tests are available here https://alimonitor.cern.ch/catalogue/?path=%2Falice%2Fcern.ch%2Fuser%2Ff%2Fffionda%2FanchorMC_4317test_NewO2DPG%2Foutput%2F526641#/alice/cern.ch/user/f/ffionda/anchorMC_4317test_NewO2DPG/output/526641 ).

[chiarazampolli]

Ported to async-v1-01-02f.