Significant MC Workflow restructuring #1790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is bigger development related to https://its.cern.ch/jira/browse/O2-3622 It makes it possible to run embedding workflows with the --pregenCollContext feature. This means that the collision structure of all timeframes are now systematically generated before any event generation or GEANT transport stage. The O2DPG MC workflows are restructured so that they * generate the collision structure (collision context) at a very high level - this contains information about how collisions are composed (background-signal) - this also fixes the vertex of the collisions - this fixes the number of background and signal events to be generated - this is now done for all timeframes at once instead of in isolation (necessary to know how many background events are needed) * thereafter we generate and transport background and signal events This restructuring leads to more consistent workflow construction and smaller code. The old option --pregenCollContext is now the enforced default.
sawenzel
requested review from
benedikt-voelkel and
chiarazampolli
as code owners
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
sawenzel
changed the title
stefanopolitano
added
async-2023-pbpb-apass4
Collaborator
|
Hi @sawenzel, DEBUG: git cherry-pick -x dbbf327 |
alcaliva
removed
the
async-2023-pbpb-apass4
alcaliva
pushed a commit
that referenced
this pull request
Jan 31, 2025
* Significant MC Workflow restructuring This is bigger development related to https://its.cern.ch/jira/browse/O2-3622 It makes it possible to run embedding workflows with the --pregenCollContext feature. This means that the collision structure of all timeframes are now systematically generated before any event generation or GEANT transport stage. The O2DPG MC workflows are restructured so that they * generate the collision structure (collision context) at a very high level - this contains information about how collisions are composed (background-signal) - this also fixes the vertex of the collisions - this fixes the number of background and signal events to be generated - this is now done for all timeframes at once instead of in isolation (necessary to know how many background events are needed) * thereafter we generate and transport background and signal events This restructuring leads to more consistent workflow construction and smaller code. The old option --pregenCollContext is now the enforced default. (cherry picked from commit dbbf327)
alcaliva
pushed a commit
that referenced
this pull request
Jan 31, 2025
* Significant MC Workflow restructuring This is bigger development related to https://its.cern.ch/jira/browse/O2-3622 It makes it possible to run embedding workflows with the --pregenCollContext feature. This means that the collision structure of all timeframes are now systematically generated before any event generation or GEANT transport stage. The O2DPG MC workflows are restructured so that they * generate the collision structure (collision context) at a very high level - this contains information about how collisions are composed (background-signal) - this also fixes the vertex of the collisions - this fixes the number of background and signal events to be generated - this is now done for all timeframes at once instead of in isolation (necessary to know how many background events are needed) * thereafter we generate and transport background and signal events This restructuring leads to more consistent workflow construction and smaller code. The old option --pregenCollContext is now the enforced default. (cherry picked from commit dbbf327)
alcaliva
pushed a commit
that referenced
this pull request
Jan 31, 2025
* Significant MC Workflow restructuring This is bigger development related to https://its.cern.ch/jira/browse/O2-3622 It makes it possible to run embedding workflows with the --pregenCollContext feature. This means that the collision structure of all timeframes are now systematically generated before any event generation or GEANT transport stage. The O2DPG MC workflows are restructured so that they * generate the collision structure (collision context) at a very high level - this contains information about how collisions are composed (background-signal) - this also fixes the vertex of the collisions - this fixes the number of background and signal events to be generated - this is now done for all timeframes at once instead of in isolation (necessary to know how many background events are needed) * thereafter we generate and transport background and signal events This restructuring leads to more consistent workflow construction and smaller code. The old option --pregenCollContext is now the enforced default. (cherry picked from commit dbbf327)
alcaliva
pushed a commit
that referenced
this pull request
Jan 31, 2025
* Significant MC Workflow restructuring This is bigger development related to https://its.cern.ch/jira/browse/O2-3622 It makes it possible to run embedding workflows with the --pregenCollContext feature. This means that the collision structure of all timeframes are now systematically generated before any event generation or GEANT transport stage. The O2DPG MC workflows are restructured so that they * generate the collision structure (collision context) at a very high level - this contains information about how collisions are composed (background-signal) - this also fixes the vertex of the collisions - this fixes the number of background and signal events to be generated - this is now done for all timeframes at once instead of in isolation (necessary to know how many background events are needed) * thereafter we generate and transport background and signal events This restructuring leads to more consistent workflow construction and smaller code. The old option --pregenCollContext is now the enforced default. (cherry picked from commit dbbf327)
alcaliva
pushed a commit
that referenced
this pull request
Feb 2, 2025
* Significant MC Workflow restructuring This is bigger development related to https://its.cern.ch/jira/browse/O2-3622 It makes it possible to run embedding workflows with the --pregenCollContext feature. This means that the collision structure of all timeframes are now systematically generated before any event generation or GEANT transport stage. The O2DPG MC workflows are restructured so that they * generate the collision structure (collision context) at a very high level - this contains information about how collisions are composed (background-signal) - this also fixes the vertex of the collisions - this fixes the number of background and signal events to be generated - this is now done for all timeframes at once instead of in isolation (necessary to know how many background events are needed) * thereafter we generate and transport background and signal events This restructuring leads to more consistent workflow construction and smaller code. The old option --pregenCollContext is now the enforced default. (cherry picked from commit dbbf327)
alcaliva
pushed a commit
that referenced
this pull request
Feb 2, 2025
* Significant MC Workflow restructuring This is bigger development related to https://its.cern.ch/jira/browse/O2-3622 It makes it possible to run embedding workflows with the --pregenCollContext feature. This means that the collision structure of all timeframes are now systematically generated before any event generation or GEANT transport stage. The O2DPG MC workflows are restructured so that they * generate the collision structure (collision context) at a very high level - this contains information about how collisions are composed (background-signal) - this also fixes the vertex of the collisions - this fixes the number of background and signal events to be generated - this is now done for all timeframes at once instead of in isolation (necessary to know how many background events are needed) * thereafter we generate and transport background and signal events This restructuring leads to more consistent workflow construction and smaller code. The old option --pregenCollContext is now the enforced default. (cherry picked from commit dbbf327)
alcaliva
pushed a commit
that referenced
this pull request
Feb 2, 2025
* Significant MC Workflow restructuring This is bigger development related to https://its.cern.ch/jira/browse/O2-3622 It makes it possible to run embedding workflows with the --pregenCollContext feature. This means that the collision structure of all timeframes are now systematically generated before any event generation or GEANT transport stage. The O2DPG MC workflows are restructured so that they * generate the collision structure (collision context) at a very high level - this contains information about how collisions are composed (background-signal) - this also fixes the vertex of the collisions - this fixes the number of background and signal events to be generated - this is now done for all timeframes at once instead of in isolation (necessary to know how many background events are needed) * thereafter we generate and transport background and signal events This restructuring leads to more consistent workflow construction and smaller code. The old option --pregenCollContext is now the enforced default. (cherry picked from commit dbbf327)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bigger development related to https://its.cern.ch/jira/browse/O2-3622
It makes it possible to run embedding workflows with the --pregenCollContext feature. This means that the collision structure of all timeframes are now systematically generated before any event generation or GEANT transport stage.
The O2DPG MC workflows are restructured so that they
generate the collision structure (collision context) at a very high level
thereafter we generate and transport background and signal events
This restructuring leads to more consistent workflow construction and smaller code. The old option --pregenCollContext is now the enforced default.