Consistency fixes for SOR determination in unanchored MC #1780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just a preventive measure in case someone is using --early-orbits (avoid to get negative). In the worst case we skip few timeframes ... and in any case not a relevant change for anchored MC.
Fixes a problem with wrong/inconsistent timestamps for some runs (when not using anchoring). Now consistent with other code in O2.
sawenzel
requested review from
benedikt-voelkel and
chiarazampolli
as code owners
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
alcaliva
pushed a commit
that referenced
this pull request
Jan 31, 2025
* Set default firstOrbit to 256 just a preventive measure in case someone is using --early-orbits (avoid to get negative). In the worst case we skip few timeframes ... and in any case not a relevant change for anchored MC. * Better SOR determination Fixes a problem with wrong/inconsistent timestamps for some runs (when not using anchoring). Now consistent with other code in O2. (cherry picked from commit 5f6131a)
alcaliva
pushed a commit
that referenced
this pull request
Jan 31, 2025
* Set default firstOrbit to 256 just a preventive measure in case someone is using --early-orbits (avoid to get negative). In the worst case we skip few timeframes ... and in any case not a relevant change for anchored MC. * Better SOR determination Fixes a problem with wrong/inconsistent timestamps for some runs (when not using anchoring). Now consistent with other code in O2. (cherry picked from commit 5f6131a)
alcaliva
pushed a commit
that referenced
this pull request
Jan 31, 2025
* Set default firstOrbit to 256 just a preventive measure in case someone is using --early-orbits (avoid to get negative). In the worst case we skip few timeframes ... and in any case not a relevant change for anchored MC. * Better SOR determination Fixes a problem with wrong/inconsistent timestamps for some runs (when not using anchoring). Now consistent with other code in O2. (cherry picked from commit 5f6131a)
alcaliva
pushed a commit
that referenced
this pull request
Jan 31, 2025
* Set default firstOrbit to 256 just a preventive measure in case someone is using --early-orbits (avoid to get negative). In the worst case we skip few timeframes ... and in any case not a relevant change for anchored MC. * Better SOR determination Fixes a problem with wrong/inconsistent timestamps for some runs (when not using anchoring). Now consistent with other code in O2. (cherry picked from commit 5f6131a)
alcaliva
pushed a commit
that referenced
this pull request
Feb 2, 2025
* Set default firstOrbit to 256 just a preventive measure in case someone is using --early-orbits (avoid to get negative). In the worst case we skip few timeframes ... and in any case not a relevant change for anchored MC. * Better SOR determination Fixes a problem with wrong/inconsistent timestamps for some runs (when not using anchoring). Now consistent with other code in O2. (cherry picked from commit 5f6131a)
alcaliva
pushed a commit
that referenced
this pull request
Feb 2, 2025
* Set default firstOrbit to 256 just a preventive measure in case someone is using --early-orbits (avoid to get negative). In the worst case we skip few timeframes ... and in any case not a relevant change for anchored MC. * Better SOR determination Fixes a problem with wrong/inconsistent timestamps for some runs (when not using anchoring). Now consistent with other code in O2. (cherry picked from commit 5f6131a)
alcaliva
pushed a commit
that referenced
this pull request
Feb 2, 2025
* Set default firstOrbit to 256 just a preventive measure in case someone is using --early-orbits (avoid to get negative). In the worst case we skip few timeframes ... and in any case not a relevant change for anchored MC. * Better SOR determination Fixes a problem with wrong/inconsistent timestamps for some runs (when not using anchoring). Now consistent with other code in O2. (cherry picked from commit 5f6131a)
maciacco
pushed a commit
to maciacco/O2DPG
that referenced
this pull request
Feb 13, 2025
…p#1780) * Set default firstOrbit to 256 just a preventive measure in case someone is using --early-orbits (avoid to get negative). In the worst case we skip few timeframes ... and in any case not a relevant change for anchored MC. * Better SOR determination Fixes a problem with wrong/inconsistent timestamps for some runs (when not using anchoring). Now consistent with other code in O2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.