Avoid looking for protobuf, kafka, grpc if requested #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the issue some people are having when building monitoring without online components (e.g. for analysis), while having protobuf / grpc / abseil on the system for whatever reason. In that scenario, the old behavior results in picking up a potentially incompatible protobuf from the system and consequent build errors. In order to keep backward compatible behavior, I made the options on by default, I will make sure in alidist the correct options are chosen when building a non-dataflow configuration.
Member
Author
|
@sy-c can we have this merged and a new release cut with it? Current behaviour is now breaking the builds of many analysers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue some people are having when building monitoring without
online components (e.g. for analysis), while having protobuf / grpc / abseil on the system
for whatever reason.
In that scenario, the old behavior results in picking up a potentially incompatible
protobuf from the system and consequent build errors.
In order to keep backward compatible behavior, I made the options on by default,
I will make sure in alidist the correct options are chosen when building a non-dataflow
configuration.