Skip to content

Conversation

@justonedev1
Copy link

@justonedev1 justonedev1 commented Jun 2, 2025

@sy-c can you take a look at this please?

@sy-c
Copy link
Collaborator

sy-c commented Jun 3, 2025

Although I have nothing against the implementation you propose, it seems to me wrong to do such sorting here. This is a simple bridge with no knowledge about detectors or other semantics. Hardcoding "ITS" in this place looks incorrect in this component, it should have no control logic associated to it.

If sorting is needed for whatever reason, it should be done either on the source publishing the info or on the consumer side.
The purpose of the bridge is just to publish the information as it comes in.

@justonedev1
Copy link
Author

I was thinking in exact opposite sense: "consumer should do whatever they want with the data, as ECS (publisher) doesn't care about the order and shouldn't care about the order". But sadly as far to my knowledge grafana (consumer of the data) doesn't allow sorting easily, so I did it here as this was in my eyes the closest "consumer"... However if you refuse this as a maintainer, I will move it to the source as it is the only solution left.

@justonedev1 justonedev1 closed this Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants