Inverse logic to use smaps_rollup #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider not having smaps_rollup a special case, rather than the other way around.
sy-c
approved these changes
Jan 23, 2025
fixed name of constant for CC7
sy-c
approved these changes
Jan 23, 2025
Collaborator
sy-c
left a comment
sy-c
left a comment
There was a problem hiding this comment.
I've done a minor change:
O2_MONITORING_OS_CS7 should be O2_MONITORING_OS_CC7
as defined in the CMAKE.
Member
Author
|
Can we have a release with this in? |
Collaborator
|
Sure, this was done on Friday. It has been bumped in alisw/alidist#5712 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider not having smaps_rollup a special case, rather than the other
way around.