Skip to content

Conversation

@justonedev1
Copy link
Collaborator

I think that this fixes what George wanted, but I need for him to verify it.

@justonedev1 justonedev1 requested a review from knopers8 as a code owner October 14, 2025 16:14
@justonedev1 justonedev1 changed the title OCTRL-1051: added error messages to CreateAutoEnvironment [OCTRL-1051] Missing Error & Done Kafka events for early failed NewAutoEnvironment Oct 14, 2025
@justonedev1
Copy link
Collaborator Author

justonedev1 commented Oct 14, 2025

I tested on STG. From calibration page:

It can be used by anyone with ITS lock to test the auto transition environment
[10/14/2025, 6:18:30 PM] : Stream has now ended
[10/14/2025, 6:18:30 PM] ID: 2xWyLsTkjW6 due to cannot load workflow template: 2 errors occurred: * unknown name hosts (1:2) | hosts | .^ * json: cannot unmarshal object into Go value of type []string
[10/14/2025, 6:18:30 PM] : request was sent to AliECS
image

So it seems that this fixes the issue.

@graduta
Copy link
Member

graduta commented Oct 14, 2025

I tested on STG. From calibration page:

It can be used by anyone with ITS lock to test the auto transition environment
[10/14/2025, 6:18:30 PM] : Stream has now ended
[10/14/2025, 6:18:30 PM] ID: 2xWyLsTkjW6 due to cannot load workflow template: 2 errors occurred: * unknown name hosts (1:2) | hosts | .^ * json: cannot unmarshal object into Go value of type []string
[10/14/2025, 6:18:30 PM] : request was sent to AliECS
image

So it seems that this fixes the issue.

I had a look at the Kafka messages for this environment and the GUI processed ones and your fix looks good to me. Thank you for the quick follow up!

err = fmt.Errorf("cannot load workflow template: %w", err)
env.sendEnvironmentEvent(&event.EnvironmentEvent{EnvironmentID: env.Id().String(), Error: err})

log.WithError(err).Logf(logrus.ErrorLevel, "failed to load workflow")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
log.WithError(err).Logf(logrus.ErrorLevel, "failed to load workflow")
log.WithError(err).Error("failed to load workflow")

that's a simpler way to write it.

@knopers8 knopers8 merged commit f03795d into master Oct 15, 2025
4 checks passed
@knopers8 knopers8 deleted the OCTRL-1051 branch October 15, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants