OCTRL-1049 Stop tasks within GO_ERROR transition #756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves stopping RUNNING tasks into GO_ERROR transition, so that the stop order makes sense - FLP and EPN tasks stop roughly in parallel. Before, FLP tasks would be stopped only after EPN tasks, which was preventing EPNs to finalize certain computations and was generally opposite to the data flow. I could not see any unwanted side effects of this change, seemed good on staging.
justonedev1
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves stopping RUNNING tasks into GO_ERROR transition, so that the stop order makes sense - FLP and EPN tasks stop roughly in parallel. Before, FLP tasks would be stopped only after EPN tasks, which was preventing EPNs to finalize certain computations and was generally opposite to the data flow.
I could not see any unwanted side effects of this change, seemed good on staging.