Skip to content

OCTRL-981: Do not print error for BASIC_TASK_TERMINATED event with no parent role #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knopers8 merged 4 commits into from
Aug 26, 2025
Merged

OCTRL-981: Do not print error for BASIC_TASK_TERMINATED event with no parent role #741

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8a651e4
Initial plan
Copilot Aug 19, 2025
658b099
Fix printf formatting directive issue in task manager
Copilot Aug 19, 2025
ad7fdf5
Fix race condition: Change error to debug for BASIC_TASK_TERMINATED w…
Copilot Aug 19, 2025
74156bf
OCTRL-981: Remove unrelated changes - keep only environment manager fix
Copilot Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion core/environment/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1070,10 +1070,13 @@ func (envs *Manager) handleDeviceEvent(evt event.DeviceEvent) {
}
}
} else {
// Task has no parent role - this can happen during environment teardown
// when tasks are released before termination events are processed
log.WithPrefix("scheduler").
WithField("partition", envId.String()).
WithField("taskId", taskId.Value).
WithField(infologger.Level, infologger.IL_Devel).
Error("DeviceEvent BASIC_TASK_TERMINATED received for task with no parent role")
Debug("DeviceEvent BASIC_TASK_TERMINATED received for task with no parent role, likely due to environment teardown")
}
} else {
log.WithPrefix("scheduler").
Expand Down
Loading