Skip to content

[core] propagate original_run_number as FairMQ property to tasks #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justonedev1 merged 1 commit into from
Jul 1, 2025
Merged

[core] propagate original_run_number as FairMQ property to tasks #726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/environment/transition_startactivity.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ func (t StartActivityTransition) do(env *Environment) (err error) {
"lhc_period",
"pdp_beam_type",
"pdp_override_run_start_time",
"original_run_number",
} {
if value, ok := cvs[key]; ok {
// we push the above parameters with both camelCase and snake_case identifiers for convenience
Expand Down
4 changes: 4 additions & 0 deletions core/integration/odc/plugin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1365,6 +1365,7 @@ func (p *Plugin) CallStack(data interface{}) (stack map[string]interface{}) {
WithField("call", "Start").
Warn("cannot acquire run number for ODC")
}
originalRunNumber, _ := varStack["original_run_number"]
cleanupCountS, ok := varStack["__fmq_cleanup_count"]
if !ok {
log.WithField("partition", envId).
Expand Down Expand Up @@ -1407,6 +1408,9 @@ func (p *Plugin) CallStack(data interface{}) (stack map[string]interface{}) {
arguments["runNumber"] = rn
arguments["run_start_time_ms"] = runStartTimeMs
arguments["cleanup"] = strconv.Itoa(cleanupCount)
if len(originalRunNumber) > 0 {
arguments["original_run_number"] = originalRunNumber
}

ctx, cancel := context.WithTimeout(context.Background(), timeout)
defer cancel()
Expand Down
1 change: 1 addition & 0 deletions docs/handbook/configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,6 +443,7 @@ In addition to the above, which varies depending on the configuration of the env
* `lhcPeriod`
* `pdp_beam_type`
* `pdp_override_run_start_time`
* `original_run_number`

The following values are pushed by AliECS during `STOP_ACTIVITY`:

Expand Down