Skip to content

[core] Counting number of status updates in transition_deploy #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
justonedev1 wants to merge 1 commit into from
Closed

[core] Counting number of status updates in transition_deploy #679

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions core/environment/transition_deploy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,13 @@ func (t DeployTransition) do(env *Environment) (err error) {

deploymentTimeout := acquireDeploymentTimeout(wf)

numberOfLeaves := 0
workflow.LeafWalk(wf, func(role workflow.Role) {
numberOfLeaves += 1
})

numberOfStatusChanges := 0

wfStatus := wf.GetStatus()
if wfStatus != task.ACTIVE {
log.WithField("partition", env.Id().String()).
Expand All @@ -228,6 +235,8 @@ func (t DeployTransition) do(env *Environment) (err error) {
log.WithField("status", wfStatus.String()).
WithField("partition", env.Id().String()).
Debug("workflow status change")
numberOfStatusChanges += 1

if wfStatus == task.ACTIVE {
break WORKFLOW_ACTIVE_LOOP
} else if wfStatus == task.UNDEPLOYABLE {
Expand Down Expand Up @@ -255,7 +264,11 @@ func (t DeployTransition) do(env *Environment) (err error) {
inactiveTaskRolesS := strings.Join(undeployableTaskRoles, ", ")

err = fmt.Errorf("workflow deployment failed (one or more roles undeployable), aborting and cleaning up [undeployable roles: %s]", inactiveTaskRolesS)
break WORKFLOW_ACTIVE_LOOP
}

if numberOfStatusChanges >= numberOfLeaves {
err = fmt.Errorf("workflow did not receive ACTIVE status after all (%d) roles reported their statuses", numberOfLeaves)
break WORKFLOW_ACTIVE_LOOP
}
continue
Expand Down