Skip to content

Conversation

@singiamtel
Copy link
Collaborator

@singiamtel singiamtel commented Nov 4, 2024

Should fix the CI issues on #46 and #47

CC @ktf

The required job clang-format-8 has to be changed when merging

@ktf
Copy link
Member

ktf commented Nov 7, 2024

Is this triggering new formatting errors?

@singiamtel
Copy link
Collaborator Author

Is this triggering new formatting errors?

Hmm, good question. Apparently it wants to change //comments to // comments, and remove a few newlines at the end of files. How should we proceed?

The changes when formatting everything:

 src/Configuration.cxx     | 3 +--
 src/Daemon.cxx            | 1 -
 src/Exception.cxx         | 1 -
 src/Iommu.cxx             | 1 -
 src/LineBuffer.cxx        | 3 +--
 src/MemPool.cxx           | 5 ++---
 src/Program.cxx           | 1 -
 src/SimpleLog.cxx         | 3 +--
 src/SuffixNumber.cxx      | 1 -
 src/System.cxx            | 1 -
 src/Thread.cxx            | 1 -
 test/TestBasicThread.cxx  | 1 -
 test/TestIommu.cxx        | 1 -
 test/TestSuffixNumber.cxx | 1 -
 test/TestSuffixOption.cxx | 1 -
 test/TestSystem.cxx       | 1 -
 test/testDaemon.cxx       | 1 -
 test/testFifo.cxx         | 1 -
 test/testSimpleLog.cxx    | 7 +++----
 test/testTimer.cxx        | 1 -
 20 files changed, 8 insertions(+), 28 deletions(-)

@ktf
Copy link
Member

ktf commented Nov 12, 2024

@sy-c can you have a look if this is fine for you? In principle it matches better the coding conventions and it seems trivial changes.

@sy-c
Copy link
Collaborator

sy-c commented Nov 14, 2024

Hello @ktf, ok for me.

singiamtel added a commit to singiamtel/Common that referenced this pull request Nov 14, 2024
@ktf ktf merged commit 57cd35b into AliceO2Group:master Nov 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants