Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
5e62f29
[O2B-1528] Fix spelling
isaachilly Jan 30, 2026
84aceda
[O2B-1528] Fix typo: verifiedd_flags_list
isaachilly Jan 30, 2026
7e1c0c4
[O2B-1528] Support per-run GAQ summary fetching
isaachilly Jan 30, 2026
67564ed
[O2B-1528] Await GAQ summary fetches sequentially
isaachilly Jan 30, 2026
b8decec
[O2B-1528] Require runNumber for GAQ summary requests to avoid databa…
isaachilly Jan 30, 2026
9f122fe
[O2B-1528] Validate dataPassId and runNumber as positive
isaachilly Jan 30, 2026
a5768c7
[O2B-1528] Update GAQ test with enabling of GAQ summary again
isaachilly Jan 30, 2026
89a09ee
[O2B-1528] Add validation tests for GAQ summary endpoint
isaachilly Jan 30, 2026
f3533d0
[O2B-1528] Make GAQ summary fetches cancelable
isaachilly Feb 3, 2026
f6edc96
[O2B-1528] Failed to store GAQ summary correctly
isaachilly Feb 3, 2026
d020ac8
[O2B-1528] Add GAQ summary multiple request test
isaachilly Feb 4, 2026
e6e6388
Merge branch 'main' into improv/O2B-1528/Split-GAQ-summary-requests
isaachilly Feb 4, 2026
58081a4
[O2B-1528] Avoid variable shadowing in GAQ summary mapping
isaachilly Feb 9, 2026
ccead8e
[O2B-1528] Use per-run GAQ summary remote data sources
isaachilly Feb 9, 2026
40f92b3
Merge branch 'main' into improv/O2B-1528/Split-GAQ-summary-requests
isaachilly Feb 9, 2026
8dfc023
Merge branch 'main' into improv/O2B-1528/Split-GAQ-summary-requests
graduta Feb 9, 2026
a90dd98
Merge branch 'main' into improv/O2B-1528/Split-GAQ-summary-requests
isaachilly Feb 10, 2026
7622a8c
[O2B-1528] Non-blocking GAQ fetch and fix display of failure
isaachilly Feb 11, 2026
035d870
Merge branch 'main' into improv/O2B-1528/Split-GAQ-summary-requests
isaachilly Feb 11, 2026
feda914
[O2B-1528] Remove unnecessary async
isaachilly Feb 11, 2026
3f7d597
EBF version patch
graduta Feb 11, 2026
8976f4e
Revert unintended change
graduta Feb 11, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ export class RunsPerDataPassOverviewModel extends FixedPdpBeamTypeRunsOverviewMo
const { signal } = this._gaqSequenceAbortController;

this._item$.getCurrent().match({
Success: async (runs) => {
Success: (runs) => {
const runNumbers = runs.map((run) => run.runNumber);

// Prepare GAQ summary object with NotAsked RemoteData state for all runs
Expand All @@ -398,7 +398,7 @@ export class RunsPerDataPassOverviewModel extends FixedPdpBeamTypeRunsOverviewMo
return;
}

await this._fetchGaqSummary(runNumber);
this._fetchGaqSummary(runNumber);
}
},
Other: () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,16 @@ export const RunsPerDataPassOverviewPage = ({
},
Loading: () => tooltip(gaqLoadingSpinner, 'Loading GAQ summary...'),
NotAsked: () => tooltip(gaqLoadingSpinner, 'Loading GAQ summary...'),
Failure: () => tooltip(iconWarning(), 'Failed to load GAQ summary'),
Failure: () => {
const gaqDisplay = h('button.btn.btn-primary.w-100', [
'GAQ',
h(
'.d-inline-block.va-t-bottom',
tooltip(h('.f7', iconWarning()), 'GAQ Summary failed, please click to view GAQ flags'),
),
]);
return frontLink(gaqDisplay, 'gaq-flags', { dataPassId, runNumber });
},
});
},
filter: ({ filteringModel }) => numericalComparisonFilter(
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@aliceo2/bookkeeping",
"version": "1.17.0",
"version": "1.17.1",
"author": "ALICEO2",
"repository": {
"type": "git",
Expand Down
Loading