-
Notifications
You must be signed in to change notification settings - Fork 21
[O2B-1502] Add Filtering panel to LHC-fills page #2030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[O2B-1502] Add Filtering panel to LHC-fills page #2030
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2030 +/- ##
==========================================
- Coverage 45.47% 45.33% -0.14%
==========================================
Files 1023 1026 +3
Lines 17053 17102 +49
Branches 3092 3108 +16
==========================================
Hits 7754 7754
- Misses 9299 9348 +49 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…achine hitting timout threshold
This reverts commit 96a04c0.
graduta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Houwie7000 , very good initiative into extracting duplicated code into reusable components!
I left a few comments to improve the code readability but also maintainability in the case of how the filtering model is currently implemented. Please let me know if you have any questions
This reverts commit 695622b.
…ith the query/reset logic. Just set the value afterwards
lib/public/components/Filters/LhcFillsFilter/StableBeamFilterModel.js
Outdated
Show resolved
Hide resolved
graduta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job on customizing the StableBeamsFilterModel
There are a few more changes before we can approve the PR
I have a JIRA ticket
Notable changes for users:
Notable changes for developers:
Changes made to the database:
I extracted the radio button component since it was repeated in dcs/epn/ddflp filters and would be repeated again in the stableBeamFilter otherwise.