Skip to content

Conversation

@Houwie7000
Copy link
Collaborator

@Houwie7000 Houwie7000 commented Nov 26, 2025

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • LHC-fills page now has a filter button/modal (only includes 'stable beams only' for now)

Notable changes for developers:

  • RadioButtons used in dcs/epn/ddflp filters have been extracted to a seperate component, inline with the reworked stableBeamFilter

Changes made to the database:

  • None

I extracted the radio button component since it was repeated in dcs/epn/ddflp filters and would be repeated again in the stableBeamFilter otherwise.

@Houwie7000 Houwie7000 self-assigned this Nov 26, 2025
@Houwie7000 Houwie7000 added frontend javascript Pull requests that update Javascript code labels Nov 26, 2025
@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

❌ Patch coverage is 0% with 75 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.33%. Comparing base (bff8c8f) to head (412fcad).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...c/views/LhcFills/Overview/LhcFillsOverviewModel.js 0.00% 18 Missing ⚠️
...ts/Filters/LhcFillsFilter/StableBeamFilterModel.js 0.00% 14 Missing ⚠️
...ponents/Filters/LhcFillsFilter/stableBeamFilter.js 0.00% 11 Missing ⚠️
...ublic/components/common/form/inputs/radioButton.js 0.00% 9 Missing ⚠️
lib/public/components/Filters/RunsFilter/dcs.js 0.00% 7 Missing ⚠️
lib/public/components/Filters/RunsFilter/ddflp.js 0.00% 7 Missing ⚠️
lib/public/components/Filters/RunsFilter/epn.js 0.00% 7 Missing ⚠️
...ws/LhcFills/ActiveColumns/lhcFillsActiveColumns.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2030      +/-   ##
==========================================
- Coverage   45.47%   45.33%   -0.14%     
==========================================
  Files        1023     1026       +3     
  Lines       17053    17102      +49     
  Branches     3092     3108      +16     
==========================================
  Hits         7754     7754              
- Misses       9299     9348      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Houwie7000 Houwie7000 requested a review from isaachilly December 1, 2025 10:41
@Houwie7000 Houwie7000 marked this pull request as ready for review December 1, 2025 10:41
@Houwie7000 Houwie7000 requested a review from graduta as a code owner December 1, 2025 10:41
Copy link
Member

@graduta graduta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Houwie7000 , very good initiative into extracting duplicated code into reusable components!
I left a few comments to improve the code readability but also maintainability in the case of how the filtering model is currently implemented. Please let me know if you have any questions

Copy link
Member

@graduta graduta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on customizing the StableBeamsFilterModel
There are a few more changes before we can approve the PR

@Houwie7000 Houwie7000 requested a review from graduta December 15, 2025 11:20
@graduta graduta merged commit aace7a6 into main Dec 15, 2025
21 of 24 checks passed
@graduta graduta deleted the feature/O2B-1502/filtering-panel-lhc-fills-frontend branch December 15, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend javascript Pull requests that update Javascript code

Development

Successfully merging this pull request may close these issues.

4 participants