[O2B-1490] Add filtering by env ids to the environment filtering panel #2028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integrated the filtersPanelPopover component into the environment overview UI. Added a test to verify that the filtering panel can be successfully opened.
Adds FilteringModel to EnvironmentOverviewModel, enabling filter state management.
Introduces a raw text filter for environment IDs in the environments overview. Adds tests to verify filtering by single and multiple IDs.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2028 +/- ##
==========================================
- Coverage 45.47% 45.45% -0.03%
==========================================
Files 1023 1023
Lines 17050 17051 +1
Branches 3092 3092
==========================================
- Hits 7754 7750 -4
- Misses 9296 9301 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…-environment-filtering-panel
Removed the overridden getLoadParameters method from EnvironmentOverviewModel.
graduta
requested changes
Nov 26, 2025
test/public/envs/overview.test.js
Outdated
| await fillInput(page, selector, inputValue, ['change']); | ||
| await waitForTableLength(page, expectedIds.length); | ||
| const table = await page.$$('tbody tr'); | ||
| expect(table.length).to.equal(expectedIds.length); |
Member
There was a problem hiding this comment.
As far as I can tell, the waitForTableLength will already confirm the expected number of environments, so there is no need for this check.
I would even go further (as front-end tests tend to be quite slow), that the placeholder, we check it once at the start of the test, and then for each reset of filters, we do not recheck it to save just a bit of time.
Houwie7000
previously approved these changes
Nov 26, 2025
Eliminated an unnecessary table length check that could slow down test speed.
graduta
previously approved these changes
Dec 5, 2025
Changed the filter input and expected results for a test case with filtering on env IDs. This is because test inputs following each other that result in the same number of rows in the table will cause incorrect functioning of the waitForTableLength whose job it is is to wait for the filter to be applied.
graduta
deleted the
feature/O2B-1490/Add-filtering-by-env-ids-to-environment-filtering-panel
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a raw text filter for environment IDs in the environments overview.
Adds tests to verify filtering by single and multiple IDs.
I have a JIRA ticket
Notable changes for users:
Notable changes for developers:
Changes made to the database: