-
Notifications
You must be signed in to change notification settings - Fork 0
[O2B-1474] Add kafka producer for beam mode change on stable beams #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[O2B-1474] Add kafka producer for beam mode change on stable beams #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a Kafka producer to emit beam mode change events (for stable beams lifecycle) serialized with Protocol Buffers, integrates it into the DIP message processing flow, and introduces the corresponding .proto schemas and documentation updates.
- Introduces common and event protobuf schemas (BeamInfo, BeamMode, Ev_BeamModeEvent).
- Adds a generic Kafka producer wrapper and a BeamMode-specific producer, wiring it into DipMessagesProcessor and lifecycle management in AliDip2BK.
- Updates README with purpose, requirements, and the new published event topic.
Reviewed Changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| src/alice/dip/protos/protos/common.proto | Adds common protobuf types (User, WorkflowTemplateInfo, BeamInfo, BeamMode) used by events. |
| src/alice/dip/protos/events.proto | Defines event messages including Ev_BeamModeEvent and references common types. |
| src/alice/dip/kafka/KafkaProducerInterface.java | Provides a generic Kafka producer wrapper used by the BeamMode producer. |
| src/alice/dip/kafka/BeamModeEventsKafkaProducer.java | Implements producer for beam mode events; serializes to protobuf and sends to Kafka. |
| src/alice/dip/DipMessagesProcessor.java | Integrates the BeamMode producer and emits events on beam mode transitions. |
| src/alice/dip/AliDip2BK.java | Creates, injects, and closes the BeamMode Kafka producer in the app lifecycle. |
| README.md | Updates project description, requirements, and documents the new Kafka topic. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 8 out of 10 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…ature/O2B-1474/add-kafka-producer-for-beam-mode-change-on-SB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 9 out of 11 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Closed in favour of: #15 |
PR which:
protofiles that are to be used for publishing kafka events