Skip to content

Conversation

@fgrosa
Copy link
Collaborator

@fgrosa fgrosa commented Oct 14, 2025

In #14698 I wrongly thought that I could exclude the particles from background event to count the collisions to reduce the size of the vector, without considering that if the embedding pattern different from @0:e1, there are collisions with only background particles.
This PR fixes this bug @sawenzel

@fgrosa fgrosa requested a review from a team as a code owner October 14, 2025 11:44
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for f7f0765 at 2025-10-14 23:16:

++ cp /sw/slc9_x86-64/O2/14735-slc9_x86-64-local1/compile_commands.json .
+++ python3 -c 'import json, os; print(os.path.commonpath([x["file"] for x in json.loads(open("compile_commands.json").read()) if "sw/BUILD" not in x["file"] and "G__" not in x["file"] and x["file"].endswith(".cxx")]))'
++ O2_SRC=/sw/SOURCES/O2/14735-slc9_x86-64/0
++ [[ -e /sw/SOURCES/O2/14735-slc9_x86-64/0/CMakeLists.txt ]]

Full log here.

@alcaliva alcaliva enabled auto-merge (squash) October 16, 2025 11:33
@alcaliva alcaliva merged commit 21d965e into AliceO2Group:dev Oct 16, 2025
13 checks passed
alcaliva pushed a commit that referenced this pull request Oct 21, 2025
plariono pushed a commit to plariono/AliceO2 that referenced this pull request Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants