Skip to content

Account for rejected clusters in unbinned residuals counters #14724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shahor02 merged 1 commit into from
Oct 7, 2025
Merged

Account for rejected clusters in unbinned residuals counters #14724

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Detectors/TPC/calibration/SpacePoints/src/TrackInterpolation.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -640,7 +640,6 @@ void TrackInterpolation::interpolateTrack(int iSeed)
// skip masked cluster residual
continue;
}
++nClValidated;
const float tgPhi = clusterResiduals[iCl].snp / std::sqrt((1.f - clusterResiduals[iCl].snp) * (1.f + clusterResiduals[iCl].snp));
const auto dy = clusterResiduals[iCl].dy;
const auto dz = clusterResiduals[iCl].dz;
Expand All @@ -649,6 +648,7 @@ void TrackInterpolation::interpolateTrack(int iSeed)
const auto sec = clusterResiduals[iCl].sec;
if ((std::abs(dy) < param::MaxResid) && (std::abs(dz) < param::MaxResid) && (std::abs(y) < param::MaxY) && (std::abs(z) < param::MaxZ) && (std::abs(tgPhi) < param::MaxTgSlp)) {
mClRes.emplace_back(dy, dz, tgPhi, y, z, iRow, sec);
++nClValidated;
} else {
++mRejectedResiduals;
}
Expand Down Expand Up @@ -875,7 +875,7 @@ void TrackInterpolation::extrapolateTrack(int iSeed)

TrackParams params; // for refitted track parameters and flagging rejected clusters
if (clusterResiduals.size() > constants::MAXGLOBALPADROW) {
LOGP(warn, "Extrapolated ITS-TPC track and found more reesiduals than possible ({})", clusterResiduals.size());
LOGP(warn, "Extrapolated ITS-TPC track and found more residuals than possible ({})", clusterResiduals.size());
return;
}

Expand All @@ -899,14 +899,14 @@ void TrackInterpolation::extrapolateTrack(int iSeed)
if (iRow < param::NPadRows && params.flagRej[iCl]) { // skip masked cluster residual
continue;
}
++nClValidated;
const float tgPhi = clusterResiduals[iCl].snp / std::sqrt((1.f - clusterResiduals[iCl].snp) * (1.f + clusterResiduals[iCl].snp));
const auto dy = clusterResiduals[iCl].dy;
const auto dz = clusterResiduals[iCl].dz;
const auto y = clusterResiduals[iCl].y;
const auto z = clusterResiduals[iCl].z;
if ((std::abs(dy) < param::MaxResid) && (std::abs(dz) < param::MaxResid) && (std::abs(y) < param::MaxY) && (std::abs(z) < param::MaxZ) && (std::abs(tgPhi) < param::MaxTgSlp)) {
mClRes.emplace_back(dy, dz, tgPhi, y, z, iRow, clusterResiduals[iCl].sec);
++nClValidated;
} else {
++mRejectedResiduals;
}
Expand Down