Skip to content

Add a benchmark for stages of event mixing #14705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
saganatt wants to merge 2 commits into from
Closed

Add a benchmark for stages of event mixing #14705

saganatt wants to merge 2 commits into from

Conversation

@saganatt
Copy link
Collaborator

@saganatt saganatt commented Sep 29, 2025 •
edited
Loading

  • add a new benchmark to evaluate the current event mixing step-by-step
  • some fixes to the old event mixing benchmark; unfortunately, it still crashes and I have no more time to investigate it
  • remove a redundant line in ASoAHelpers benchmark

FYI @chefxxx @MykhailoShamrai

@saganatt saganatt requested a review from a team as a code owner September 29, 2025 13:45
@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

ktf
ktf reviewed Sep 30, 2025
View reviewed changes
Framework/Core/test/benchmark_ASoAHelpers.cxx
DECLARE_SOA_COLUMN_FULL(X, x, float, "x");
DECLARE_SOA_COLUMN_FULL(Y, y, float, "y");
DECLARE_SOA_COLUMN_FULL(Z, z, float, "z");
DECLARE_SOA_DYNAMIC_COLUMN(Sum, sum, [](float x, float y) { return x + y; });
Copy link
Member

@ktf ktf Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this removed?

Copy link
Collaborator Author

@saganatt saganatt Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that this column is not used anywhere in the benchmark. But, indeed, maybe it influences the timing of iterating over the table.

@ktf
Copy link
Member

ktf commented Sep 30, 2025

Please, squash the commits which can be squashed together so that it's easier to review the changes.

@saganatt
Copy link
Collaborator Author

saganatt commented Oct 1, 2025

Please, squash the commits which can be squashed together so that it's easier to review the changes.

I cleaned the PR history.

@alibuild
Copy link
Collaborator

alibuild commented Oct 8, 2025

Error while checking build/O2/fullCI_slc9 for f3e0120 at 2025-10-08 05:54:

No log files found

Full log here.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2025

This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days.

@github-actions github-actions bot added the stale label Nov 8, 2025
@github-actions github-actions bot closed this Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ktf ktf ktf left review comments

Assignees

No one assigned

Labels

stale

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@saganatt @ktf @alibuild