ITS3: improvements for simulation and reconstruction #14685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
fgrosa
reviewed
Sep 23, 2025
Collaborator
fgrosa
left a comment
fgrosa
left a comment
There was a problem hiding this comment.
Good for me, thanks! I will approve when tests are green
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
f3sch
changed the title
f3sch
requested review from
arossi81,
fprino,
mconcas and
shahor02
as code owners
Collaborator
fgrosa
approved these changes
Oct 10, 2025
mconcas
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I am anyways regenerating the material LUT, I thought I would update our build macro and also add some resemblances of the CYSS:
Additionally, this fixes the longeron clipping into the Hrings.
Also this removes the unnecessary recalculation of the cached matrix T2L which was done only for ITS3 and ensures that the matrixes are in the cache when converting the clusters and running the global matching wfx (specifically I observed it crashing for running the trd-matching).