Skip to content

Conversation

@ehellbar
Copy link
Collaborator

@ehellbar ehellbar commented Sep 5, 2025

No description provided.

@ehellbar ehellbar requested a review from a team as a code owner September 5, 2025 16:53
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@ehellbar ehellbar force-pushed the pr14656 branch 2 times, most recently from ea71866 to 1b0694d Compare September 5, 2025 17:06
@alibuild
Copy link
Collaborator

alibuild commented Sep 8, 2025

Error while checking build/O2/fullCI_slc9 for 1b0694d at 2025-09-12 04:01:

## sw/BUILD/O2-full-system-test-latest/log
Detected critical problem in logfile digi.log


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/4803c6a283ef7c6af5a2d8f4c26449868456a09a/slc9_x86-64/o2checkcode/1.0-local292/etc/modulefiles
++ cat
--

Full log here.

if (!prescale) {
prescale = 1;
}
bool noDownscaling = false;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you make this static, so that we do not always query the environment:
static bool noDownscaling = getenv("DPL_REPORT_PROCESSING_NO_DOWNSCALING") != nullptr && std::abs(atoi(getenv("DPL_REPORT_PROCESSING_NO_DOWNSCALING")))

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, done

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for 0fdbed0 at 2025-09-22 03:43:

## sw/BUILD/O2-full-system-test-latest/log
Detected critical problem in logfile digi.log


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/df08a5a34d3200cd04fdbdeb41962098412b0438/slc9_x86-64/o2checkcode/1.0-local343/etc/modulefiles
++ cat
--

Full log here.

@ehellbar
Copy link
Collaborator Author

@singiamtel the issue with the failing CCDB tests still seems to persist.

@ktf do/can you approve the PR?

@ktf ktf merged commit cbeaeab into AliceO2Group:dev Sep 22, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants