Skip to content

Conversation

@aferrero2707
Copy link
Collaborator

The pedestal processing code is modified to run in multi-threaded mode, to improve the processing speed on the calibrator node. The periodic logging of pedestals statistics is also improved, to better monitor and debug the pedestals data taking.

The multi-threading is needed because the calibrator currently runs at 100% CPU, and we think this is increasing unnecessarily the duration of the calibration runs and limiting the statistics that can be collected in a reasonable time.

@aferrero2707 aferrero2707 requested review from a team and shahor02 as code owners August 8, 2025 16:32
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@alibuild
Copy link
Collaborator

alibuild commented Aug 9, 2025

Error while checking build/O2/fullCI_slc9 for 399a65e at 2025-08-09 13:17:

++ cp /sw/slc9_x86-64/O2/14564-slc9_x86-64-local1/compile_commands.json .
+++ python3 -c 'import json, os; print(os.path.commonpath([x["file"] for x in json.loads(open("compile_commands.json").read()) if "sw/BUILD" not in x["file"] and "G__" not in x["file"] and x["file"].endswith(".cxx")]))'
++ O2_SRC=/sw/SOURCES/O2/14564-slc9_x86-64/0
++ [[ -e /sw/SOURCES/O2/14564-slc9_x86-64/0/CMakeLists.txt ]]

Full log here.

The pedestal processing code is modified to run in multi-threaded
mode, to improve the processing speed on the calibrator node

The periodic logging of pedestals statistics is also improved,
to better monitor and debug the pedestals data taking.
@aferrero2707 aferrero2707 force-pushed the mch-pedestal-calibrator-improvements branch from 3085fe2 to 88aa425 Compare August 12, 2025 16:13
@aferrero2707
Copy link
Collaborator Author

@shahor02 @ehellbar could you please review this PR, and possibly include it in the next SW release for P2? The changes are expected to improve the speed and reliability of the MCH calibrations. Thanks!

It also requires AliceO2Group/O2DPG#2089 for some related changes in the options.

Copy link
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine, though you could probably avoid being blocked by mutexes by collecting the result of different threads to dedicated containers then merging them.
Anyway, this can be done later if needed.

@shahor02 shahor02 merged commit a4605d0 into AliceO2Group:dev Aug 12, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants