Skip to content

Conversation

@shahor02
Copy link
Collaborator

@shahor02 shahor02 commented Jul 2, 2025

@ChSonnabend this should fixe the crash you reported, thanks!

@shahor02 shahor02 requested review from fprino and mconcas as code owners July 2, 2025 10:28
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@ChSonnabend
Copy link
Collaborator

Tagging also @ehellbar
Thanks for the fix @shahor02

@f3sch
Copy link
Collaborator

f3sch commented Jul 2, 2025

Can I ask what the setup was, seems a bit fringe that this then leads to a crash somewhere else?

@shahor02
Copy link
Collaborator Author

shahor02 commented Jul 2, 2025

Here is the reproducer from @ChSonnabend and @ehellbar . The ROFs vector for tracks is created as a copy of the input clusters vector then filled with the tracks counters. But this is done if at least 1 ITS track is found. If not (for whatever reason), the ROF vector will preserve the cluster counters pretending these are tracks. Then, the downstream consumers of the ITS tracks crash.
workflow.sh.gz

@f3sch
Copy link
Collaborator

f3sch commented Jul 2, 2025

indeed makes sense, thanks for fixing and sorry for introducing this regression.

@shahor02 shahor02 merged commit 76543b9 into AliceO2Group:dev Jul 2, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants