Skip to content

Conversation

@fweig
Copy link
Contributor

@fweig fweig commented Jul 1, 2025

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

davidrohr
davidrohr previously approved these changes Jul 2, 2025
Copy link
Collaborator

@davidrohr davidrohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just one comment. You can also already mark it as ready to run the CI.

@fweig fweig force-pushed the pocl-recursion-bug branch from b5dc418 to 2525d2d Compare July 2, 2025 14:52
@fweig fweig marked this pull request as ready for review July 2, 2025 14:52
@fweig fweig requested a review from sgorbuno as a code owner July 2, 2025 14:52
@alibuild
Copy link
Collaborator

alibuild commented Jul 2, 2025

Error while checking build/O2/fullCI_slc9 for 2525d2d at 2025-07-02 17:11:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/14462-slc9_x86-64/0/GPU/TPCFastTransformation/NDPiecewisePolynomials.inc:168:111: error: no matching function for call to 'o2::gpu::MultivariatePolynomialParametersHelper::getNParameters(unsigned int, unsigned int, bool)'
/sw/SOURCES/O2/14462-slc9_x86-64/0/GPU/TPCFastTransformation/NDPiecewisePolynomials.inc:219:112: error: no matching function for call to 'o2::gpu::MultivariatePolynomialParametersHelper::getNParameters(unsigned int, unsigned int, bool)'
/sw/SOURCES/O2/14462-slc9_x86-64/0/GPU/TPCFastTransformation/MultivariatePolynomial.h:59:59: error: no matching function for call to 'o2::gpu::MultivariatePolynomial<5, 4>::getNParameters(unsigned int, unsigned int, bool)'
/sw/SOURCES/O2/14462-slc9_x86-64/0/GPU/TPCFastTransformation/MultivariatePolynomial.h:59:30: error: cannot convert '<brace-enclosed initializer list>' to 'uint32_t' {aka 'unsigned int'} in initialization
/sw/SOURCES/O2/14462-slc9_x86-64/0/GPU/TPCFastTransformation/MultivariatePolynomial.h:52:218: error: no matching function for call to 'o2::gpu::MultivariatePolynomial<0, 0>::getNParameters(const uint32_t&, const uint32_t&, const bool&)'
/sw/SOURCES/O2/14462-slc9_x86-64/0/GPU/TPCFastTransformation/MultivariatePolynomial.h:52:189: error: cannot convert '<brace-enclosed initializer list>' to 'uint32_t' {aka 'unsigned int'} in initialization
/sw/SOURCES/O2/14462-slc9_x86-64/0/GPU/TPCFastTransformation/MultivariatePolynomial.h:59:59: error: no matching function for call to 'o2::gpu::MultivariatePolynomial<5, 5, true>::getNParameters(unsigned int, unsigned int, bool)'
/sw/SOURCES/O2/14462-slc9_x86-64/0/GPU/TPCFastTransformation/MultivariatePolynomial.h:59:30: error: cannot convert '<brace-enclosed initializer list>' to 'uint32_t' {aka 'unsigned int'} in initialization
ninja: build stopped: subcommand failed.

Full log here.

@fweig fweig force-pushed the pocl-recursion-bug branch from 7e658a5 to 97c2b94 Compare July 3, 2025 08:18
@alibuild
Copy link
Collaborator

alibuild commented Jul 6, 2025

Error while checking build/O2/fullCI_slc9 for 97c2b94 at 2025-07-15 11:17:

No log files found

Full log here.

Copy link
Collaborator

@sgorbuno sgorbuno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have no objections

@davidrohr davidrohr merged commit d238d41 into AliceO2Group:dev Jul 17, 2025
12 checks passed
@fweig fweig deleted the pocl-recursion-bug branch July 21, 2025 09:20
mhemmer-cern pushed a commit to mhemmer-cern/AliceO2 that referenced this pull request Sep 9, 2025
…es. (AliceO2Group#14462)

* TPCFastTransformation: Resolve recursion at compile time with templates.

* TPCFastTransformation: Fix runtime parameters on CPU for polynoms.

* Fix failing unittest.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants