Skip to content

Conversation

@f3sch
Copy link
Collaborator

@f3sch f3sch commented Jun 16, 2025

After recent refactoring, this started to push to the end of the vector, which was preallocated.
@ddobrigk this should fix the cluster size in ao2d.

After recent refactoring, this started to push to the end of the vector, which was preallocated.
@ddobrigk this should fix the cluster size in ao2d.
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@f3sch f3sch marked this pull request as ready for review June 16, 2025 13:42
@ddobrigk
Copy link
Contributor

Super thanks for the very very fast debugging @f3sch !

@shahor02
Copy link
Collaborator

@ddobrigk
Copy link
Contributor

@f3sch @ddobrigk is this related to https://its.cern.ch/jira/browse/O2-5947?focusedId=6873358&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-6873358 ?

Yes, exactly, I think this is it from private discussions - @f3sch can you confirm please?

@f3sch
Copy link
Collaborator Author

f3sch commented Jun 16, 2025

yes

Copy link
Collaborator

@fprino fprino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me. Thanks for the fix!

@mconcas mconcas merged commit 0bbb3da into dev Jun 17, 2025
14 checks passed
@mconcas mconcas deleted the f3sch-patch-2 branch June 17, 2025 04:25
matthias-kleiner pushed a commit to matthias-kleiner/AliceO2 that referenced this pull request Aug 6, 2025
mhemmer-cern pushed a commit to mhemmer-cern/AliceO2 that referenced this pull request Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

6 participants