Skip to content

Conversation

@sawenzel
Copy link
Collaborator

Allow to overwrite InteractionSampler by means of virtualizing sampling function.

Used in CollisionContextTool do allow putting collisions at fixed N intervals (export mode) for the purpose of systematic studies / debugging.

@sawenzel sawenzel requested a review from shahor02 as a code owner June 13, 2025 10:27
@sawenzel
Copy link
Collaborator Author

@f3sch

@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@sawenzel sawenzel force-pushed the swenzel/int_sampling_overwrite branch 2 times, most recently from 57ec9f0 to 518771b Compare June 13, 2025 11:17
Allow to overwrite InteractionSampler by means of virtualizing
sampling function.

Used in CollisionContextTool do allow putting collisions at fixed N intervals (export mode)
for the purpose of systematic studies / debugging.

- To use this feature say `export ALICEO2_ENFORCE_TRIVIAL_BC_SAMPLER="2:5"
  to put 5 collisions into every 2nd bunch-crossing (within the bunch filling scheme)
@sawenzel sawenzel force-pushed the swenzel/int_sampling_overwrite branch from 518771b to fdd28ae Compare June 13, 2025 11:38
@alibuild
Copy link
Collaborator

alibuild commented Jun 13, 2025

Error while checking build/O2/fullCI_slc9 for fdd28ae at 2025-06-14 10:29:

input queue has size 505
output queue has size 7
input queue has size 468
output queue has size 7
input queue has size 432
output queue has size 7
input queue has size 424
output queue has size 7
input queue has size 410
output queue has size 7
input queue has size 387
output queue has size 7
input queue has size 351
output queue has size 7
input queue has size 329
output queue has size 7
input queue has size 299
output queue has size 7
input queue has size 270
output queue has size 7
input queue has size 235
output queue has size 7
input queue has size 200
output queue has size 7
input queue has size 164
output queue has size 7
input queue has size 130
output queue has size 7
input queue has size 87
output queue has size 7
input queue has size 44
output queue has size 7
input queue has size 14
output queue has size 9
input queue has size 0
output queue has size 10
input queue has size 0
output queue has size 10
input queue has size 0
output queue has size 23
input queue has size 0
output queue has size 26
++ cp thinned_compile_commands.json compile_commands.json
++ CHECKS='-*,modernize-avoid-bind,modernize-deprecated-headers,modernize-make-shared,modernize-raw-string-literal,modernize-redundant-void-arg,modernize-replace-auto-ptr,modernize-replace-random-shuffle,modernize-shrink-to-fit,modernize-unary-static-assert,modernize-use-equals-default,modernize-use-noexcept,modernize-use-nullptr,modernize-use-override,modernize-use-transparent-functors,modernize-use-uncaught-exceptions,readability-braces-around-statements'
++ tee error-log.txt
+++ which O2codecheck
+++ find /sw/slc9_x86-64/GCC-Toolchain/v14.2.0-alice2-1/lib -name crtbegin.o -exec dirname '{}' ';'
++ run_O2CodeChecker.py -j 32 -clang-tidy-binary /sw/slc9_x86-64/o2codechecker/v18.1.2.1-local1/bin/O2codecheck -clang-apply-replacements-binary /sw/slc9_x86-64/Clang/v18.1.8-21/bin-safe/clang-apply-replacements -extra-args=--extra-arg=--gcc-install-dir=/sw/slc9_x86-64/GCC-Toolchain/v14.2.0-alice2-1/lib/gcc/x86_64-unknown-linux-gnu/14.2.0 '-header-filter=.*SOURCES(?!.*/3rdparty/).*' '-checks=-*,modernize-avoid-bind,modernize-deprecated-headers,modernize-make-shared,modernize-raw-string-literal,modernize-redundant-void-arg,modernize-replace-auto-ptr,modernize-replace-random-shuffle,modernize-shrink-to-fit,modernize-unary-static-assert,modernize-use-equals-default,modernize-use-noexcept,modernize-use-nullptr,modernize-use-override,modernize-use-transparent-functors,modernize-use-uncaught-exceptions,readability-braces-around-statements'
No checks enabled.
Unable to run clang-tidy.

Full log here.

@f3sch
Copy link
Collaborator

f3sch commented Jun 16, 2025

Hi @sawenzel, thanks again for the implementation, from what I can tell it works like I expect it to 👍

@sawenzel sawenzel merged commit 56bfdbe into AliceO2Group:dev Jun 16, 2025
10 of 11 checks passed
@sawenzel sawenzel deleted the swenzel/int_sampling_overwrite branch June 16, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants